[FLINK-26943][table] Add the built-in function DATE_ADD #24988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhz
changed the title
|
|
||
| `startDate <DATE | TIMESTAMP_WITHOUT_TIME_ZONE | TIMESTAMP_WITH_LOCAL_TIME_ZONE | CHAR | VARCHAR>, numDays <TINYINT | SMALLINT | INTEGER | BIGINT>` | ||
|
|
||
| Returns a `DATE`, `NULL` if any of the arguments are `NULL` or result overflows or date string invalid. |
There was a problem hiding this comment.
Suggested change
| Returns a `DATE`, `NULL` if any of the arguments are `NULL` or result overflows or date string invalid. | |
| Returns a `DATE`, `NULL` if any of the arguments is `NULL` or result overflows or date string is invalid. |
There was a problem hiding this comment.
It seems both of them are acceptable.
| Adds num_days days to start_date. | ||
| If num_days is negative, -num_days are subtracted from start_date. | ||
|
|
||
| null if any of the arguments are null or result overflows or date string invalid. |
There was a problem hiding this comment.
Suggested change
| null if any of the arguments are null or result overflows or date string invalid. | |
| null if any of the arguments is null or result overflows or date string is invalid. |
| /** | ||
| * Adds {@code numDays} days to {@code startDate}.<br> | ||
| * If {@code numDays} is negative, {@code -numDays} are subtracted from {@code startDate}.<br> | ||
| * null if any of the arguments are null or result overflows or date string invalid. |
There was a problem hiding this comment.
Suggested change
| * null if any of the arguments are null or result overflows or date string invalid. | |
| * null if any of the arguments is null or result overflows or date string is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add DATE_ADD supported in SQL & Table API.
Examples:
Brief change log
FLINK-26943
Verifying this change
This change added tests and can be verified as follows:
TimeFunctionsITCase#dateAddTestCasesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation