[hotfix][Table SQL / API] fix create table from values decimal issue #24981
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The following code fails on the second
fromValues
:with an exception
The reason is that the object
new BigDecimal("0.01")
has scale = 2 and precision = 1, which is not appropriate for Flink Decimal type. So, Flink Decimal type creation from BigDecimal value should be adjusted.Brief change log
ValueDataTypeConverter::convertToDecimalType
to reflect thatBigDecimal
could have precision less than scaleVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation