[FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 #24967

anupamaggarwal · 2024-06-20T12:22:37Z

What is the purpose of the change

Adds implementation of json_quote and json_unquote functions.
PR is a continuation of #24156 and addresses feedback received on the original PR.

Brief change log / changes compared to PR 24156

Diff compared to #24156 - link

Change implementation for json_quote, now with escaping logic
Change implementation for json_unquote to unescape special characters
Delegates valid json checking to SqlJsonUtils#isJsonValue
Add/ update some additional tests
Updates documentation to remove reference to MySql utf8mb4 encoding

Open questions

High level behavior for invalid json in json_unquote (pass original input as is, Vs throwing exception)
To check for JSON_VALIDITY for json_unquote logic for IS JSON is used but in certain cases IS JSON behaviour does not seem to be consistent with Json spec as documented here https://www.json.org/json-en.html
- According to json spec """" should not be a valid json (which is also flagged by JsonLint) but select '""""' IS JSON returns true
  - In case of invalid json string for json_unquote an exception is thrown in case of Mysql (However we won't do the same)

References

postgres implementation for escape

Verifying this change

Added ITs in JsonFunctionsITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

…ack from PR apache#24156 Co-authored-by: Anupam Aggarwal <[email protected]> Co-authored-by: Jeyhun Karimov <[email protected]>

…e reference to utf8mb4

flinkbot · 2024-06-20T12:26:07Z

CI report:

570d28f Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run azure re-run the last Azure build

anupamaggarwal · 2024-06-20T15:31:57Z

@flinkbot run azure

snuyanzin · 2024-07-04T07:48:56Z

Thanks for the contribution @anupamaggarwal
I checked for most cases it works well

I found one issue with symbols encoded outside of BMP

e.g.

SELECT '≠';

This works fine
now if we try it with newly added functions

SELECT json_quote('≠');

it fails as

Caused by: java.util.IllegalFormatConversionException: x != java.lang.Character
	at java.base/java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4426)
	at java.base/java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2938)
	at java.base/java.util.Formatter$FormatSpecifier.print(Formatter.java:2892)
	at java.base/java.util.Formatter.format(Formatter.java:2673)
	at java.base/java.util.Formatter.format(Formatter.java:2609)
	at java.base/java.lang.String.format(String.java:2897)
	at org.apache.flink.table.runtime.functions.scalar.JsonQuoteFunction.formatStr(JsonQuoteFunction.java:77)
	at org.apache.flink.table.runtime.functions.scalar.JsonQuoteFunction.quote(JsonQuoteFunction.java:68)
	at org.apache.flink.table.runtime.functions.scalar.JsonQuoteFunction.eval(JsonQuoteFunction.java:88)
	at StreamExecCalc$3.processElement(Unknown Source)
	at org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.pushToOperator(CopyingChainingOutput.java:75)
	at org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.collect(CopyingChainingOutput.java:50)
	at org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.collect(CopyingChainingOutput.java:29)
	at ...

I tend to think that here

	at org.apache.flink.table.runtime.functions.scalar.JsonQuoteFunction.formatStr(JsonQuoteFunction.java:77)
	at org.apache.flink.table.runtime.functions.scalar.JsonQuoteFunction.quote(JsonQuoteFunction.java:68)
	at org.apache.flink.table.runtime.functions.scalar.JsonQuoteFunction.eval(JsonQuoteFunction.java:88)

need to work with codepoints rather than chars

At the same time query

SELECT json_unquote('≠');

works fine.

I also checked same queries for MySQL and they work perfectly fine

…quote(Formatter) due to wrong (char) object type

anupamaggarwal · 2024-07-05T10:23:35Z

thanks for your review @snuyanzin !
Fixed in 4267018

snuyanzin · 2024-07-08T20:35:59Z

docs/data/sql_functions.yml

@@ -377,6 +377,12 @@ string:
  - sql: SUBSTR(string, integer1[, integer2])
    table: STRING.substr(INTEGER1[, INTEGER2])
    description: Returns a substring of string starting from position integer1 with length integer2 (to the end by default).
+  - sql: JSON_QUOTE(string)


One thing I forgot to mention: also need to update chinese doc.
It's ok to put there english version of description however it's better to keep them synced

Good point!
We can also create a Jira with a special tag to document gaps in the Chinese documentation: https://flink.apache.org/how-to-contribute/contribute-documentation/#chinese-documentation-translation

Created JIRA https://issues.apache.org/jira/browse/FLINK-35800 (and added a comment to original JIRA https://issues.apache.org/jira/browse/FLINK-34111)

Thanks for creation of jira
I would still vote for having filled chinese doc with english description which then could be translated within the jira issue you've created

sure @snuyanzin, fixed in cbcb044

snuyanzin

hm during testing I noticed 2 strange things

if escaped quote is alone or with something not UTF-8 bytes related then everything is ok e.g.

SELECT JSON_UNQUOTE('"\""'), JSON_UNQUOTE('"\"\t"');

it returns

"                              "

which is ok, however once we add utf-8 bytes like

SELECT JSON_UNQUOTE('"\"\ufffa"');

it starts printing backslash as well which is NOT OK

2.It seems current implementation allows to have multiple double quotes
e.g. this query is still working (in MySQL it fails )

SELECT JSON_UNQUOTE('"1""1"');

From one side MySQL doesn't allow this from another side I think it is still ok if it returns valid result.
However the main issue is that it fails (trace below) if we use such approach for invalid utf e.g.

 SELECT JSON_UNQUOTE('"1""\uzzzz"');

at the same time this query works fine

SELECT JSON_UNQUOTE('"1\uzzzz"');

Caused by: org.apache.flink.util.FlinkRuntimeException: java.lang.NumberFormatException: For input string: "zzzz" under radix 16
	at org.apache.flink.table.runtime.functions.scalar.JsonUnquoteFunction.eval(JsonUnquoteFunction.java:118)
	at StreamExecCalc$3.processElement(Unknown Source)
	at org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.pushToOperator(CopyingChainingOutput.java:75)
	at org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.collect(CopyingChainingOutput.java:50)
	at org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.collect(CopyingChainingOutput.java:29)
	at org.apache.flink.streaming.api.operators.StreamSourceContexts$ManualWatermarkContext.processAndCollect(StreamSourceContexts.java:425)
	at org.apache.flink.streaming.api.operators.StreamSourceContexts$WatermarkContext.collect(StreamSourceContexts.java:520)
	at org.apache.flink.streaming.api.operators.StreamSourceContexts$SwitchingOnClose.collect(StreamSourceContexts.java:110)
	at org.apache.flink.streaming.api.functions.source.InputFormatSourceFunction.run(InputFormatSourceFunction.java:100)
	at org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:113)
	at org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:71)
	at org.apache.flink.streaming.runtime.tasks.SourceStreamTask$LegacySourceFunctionThread.run(SourceStreamTask.java:338)
Caused by: java.lang.NumberFormatException: For input string: "zzzz" under radix 16
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:668)
	at org.apache.flink.table.runtime.functions.scalar.JsonUnquoteFunction.fromUnicodeLiteral(JsonUnquoteFunction.java:99)
	at org.apache.flink.table.runtime.functions.scalar.JsonUnquoteFunction.unquote(JsonUnquoteFunction.java:78)
	at org.apache.flink.table.runtime.functions.scalar.JsonUnquoteFunction.eval(JsonUnquoteFunction.java:112)
	... 11 more

UPD: i think it is better to follow existing's vendor's way like MySQL and do not allow more than 2 non-escape double quotes

fhueske

Thanks for working on this @anupamaggarwal!

I have just a few high-level comments so far.
Will dig a bit deeper into this soon.

Thank you, Fabian

docs/data/sql_functions.yml

flink-python/pyflink/table/expression.py

...able-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java

...-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala

…ative tests

anupamaggarwal · 2024-07-10T02:44:40Z

thanks @snuyanzin for your review!
I think both these cases are related to inconsistent behavior (IIUC) of IS JSON function which is used in json_unquote implementation for checking JSON validity. I had observed something similar earlier (see Open questions section of the PR description.

SELECT JSON_UNQUOTE('"1""1"');

As you pointed out this should ideally throw an exception (as mysql), however IS JSON returns true in this case (IIUC this should be a bug? since 1""1 is not a valid json)

select '"1""1"' is json; //true

If we fix this by throwing an exception (preferable), it could be in-consistent with what IS JSON considers as valid json?
Should we care about compatibility with IS JSON behavior here (or just fix this and file a JIRA for IS JSON?)

Same is the case with

SELECT JSON_UNQUOTE('"1""\uzzzz"')
select '"1""\uzzzz"' is JSON; //true

However in this case we throw an exception (from json_unquote) since \uzzzz is not a valid literal

For

SELECT JSON_UNQUOTE('"1\uzzzz"')

IS JSON returns FALSE and we return the input string back per documentation.

SELECT JSON_UNQUOTE('""\ufffa"');
it starts printing backslash as well which is NOT OK

Hmm, I tested this through the sql-client.sh, and I get " which seems expected? (as ""\ufffa" is a valid JSON )

snuyanzin · 2024-07-10T06:59:16Z

Thanks for the explanation

However in this case we throw an exception (from json_unquote) since \uzzzz is not a valid literal

that's the main point, since in related docs of this PR is written [1]

If the value starts and ends with double quotes but is not a valid JSON string literal, the value is passed through unmodified.

So based on the doc instead of exception I would expect same value as it was in input

[1] https://github.com/apache/flink/pull/24967/files#diff-539fb22ee6aeee4cf07230bb4155500c6680c4cc889260e2c58bfa9d63fb7de5R385

fhueske

Thanks for the update @anupamaggarwal!

I've found another case that we are not handling correctly.
Luckily, it doesn't depend on IS_JSON and easy to fix :-D

Thanks, Fabian

...able-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java

fhueske

Thanks for adding the quote checks and additional test cases.
I found one more thing that we should fix.

Thank you, Fabian

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java

fhueske · 2024-07-11T14:24:43Z

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java

+        } catch (Throwable t) {
+            // ignore
+        }


I don't think we should swallow any kind of exception or error.
Let's catch the errors that we expect (IllegalArgumentException, etc.) and handle those by returning the original input.
Unexpected exceptions should be forwarded because they might be related to other issues.

thanks @fhueske, @snuyanzin makes sense, fixed

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java

snuyanzin · 2024-07-11T23:54:39Z

One more diff between MySQL and Flink behavior, however this I'm not sure need to fix since at least from my point of view MySQL's behavior is questionable
MySQL

SELECT  JSON_UNQUOTE('"\\u0022\\u005c\\u005c\\u0075\\u0030\\u0030\\u0061\\u0061\\u0022"');
SELECT  JSON_UNQUOTE(JSON_UNQUOTE('"\\u0022\\u005c\\u005c\\u0075\\u0030\\u0030\\u0061\\u0061\\u0022"'));

returns

"\\u00aa"
\u00aa

Flink

SELECT  JSON_UNQUOTE('"\u0022\u005c\u005c\u0075\u0030\u0030\u0061\u0061\u0022"');
SELECT  JSON_UNQUOTE(JSON_UNQUOTE('"\u0022\u005c\u005c\u0075\u0030\u0030\u0061\u0061\u0022"'));

returns

"\\u00aa"
ª

anupamaggarwal · 2024-07-17T06:47:45Z

thanks @snuyanzin, fixed in 7546d9c

Hmm, that's strange, when I tested

SELECT JSON_UNQUOTE('"\u0022\u005c\u005c\u0075\u0030\u0030\u0061\u0061\u0022"');
SELECT JSON_UNQUOTE(JSON_UNQUOTE('"\u0022\u005c\u005c\u0075\u0030\u0030\u0061\u0061\u0022"'));

through sql-client I get the same result as MySql

I didn't entirely understand why this would be unexpected though
For example, if I test (using sql-client) with

select json_unquote('"\u00aa"'); I get ª
whereas
select json_unquote('"\\u00aa"'); returns \u00aa

which seems ok to me, unless I missed something?

Added some tests in ScalarFunctionsTest

fhueske

Thanks for the update @anupamaggarwal.

I've double checked the behavior of

SELECT JSON_UNQUOTE('"\u0022\u005c\u005c\u0075\u0030\u0030\u0061\u0061\u0022"');
SELECT JSON_UNQUOTE(JSON_UNQUOTE('"\u0022\u005c\u005c\u0075\u0030\u0030\u0061\u0061\u0022"'));

and can confirm that it is the same as in MySQL.

I think this PR is ready to be merged (just one improvement of the docs).
What do you think @snuyanzin?

fhueske · 2024-08-06T11:18:58Z

docs/data/sql_functions_zh.yml

+    description: Quotes a string as a JSON value by wrapping it with double quote characters, escaping interior quote and special characters ('"', '\', '/', 'b', 'f', 'n', 'r', 't'), and returning the result as a string. If the argument is NULL, the function returns NULL.
+  - sql: JSON_UNQUOTE(string)
+    table: STRING.JsonUnquote()
+    description: Unquotes JSON value, unescapes escaped special characters ('"', '\', '/', 'b', 'f', 'n', 'r', 't', 'u' hex hex hex hex), and returns the result as a string. If the argument is NULL, returns NULL. If the value starts and ends with double quotes but is not a valid JSON string literal, the value is passed through unmodified.


Suggested change

description: Unquotes JSON value, unescapes escaped special characters ('"', '\', '/', 'b', 'f', 'n', 'r', 't', 'u' hex hex hex hex), and returns the result as a string. If the argument is NULL, returns NULL. If the value starts and ends with double quotes but is not a valid JSON string literal, the value is passed through unmodified.

description: Unquotes JSON value, unescapes escaped special characters ('"', '\', '/', 'b', 'f', 'n', 'r', 't', 'u' hex hex hex hex), and returns the result as a string. If the argument is NULL, returns NULL. If the value does not start and ends with double quotes or if it starts and ends with double quotes but is not a valid JSON string literal, the value is passed through unmodified.

Fixed in 37fa2e7

snuyanzin · 2024-08-07T07:45:21Z

yes, probably there is something wrong with my mysql...
thanks for checking
and thanks for addressing feedback

snuyanzin · 2024-08-07T07:48:28Z

@anupamaggarwal can you please rebase to the latest master to be sure that it still passes ci ? (I tend to think that current failure is not related to the changes in PR)

anupamaggarwal · 2024-08-07T17:22:23Z

@flinkbot run azure

anupamaggarwal · 2024-08-08T03:33:46Z

Thanks @snuyanzin I pulled the latest from master on my branch and the build is passing now (It seems CI is a bit flaky since one of the runs post merge failed but the second went through). The failure didn't seem related to this change though.

snuyanzin · 2024-08-08T10:37:41Z

Cool, thanks for your contribution @anupamaggarwal
thanks for the review @fhueske

if there is no objections I'm going to merge later today or tomorrow

fhueske · 2024-08-09T07:59:23Z

Thank you both @anupamaggarwal and @snuyanzin!

anupamaggarwal and others added 5 commits June 20, 2024 09:40

[FLINK-34111] Add support for json_quote, json_unquote, address feedb…

42bbced

…ack from PR apache#24156 Co-authored-by: Anupam Aggarwal <[email protected]> Co-authored-by: Jeyhun Karimov <[email protected]>

[FLINK-34111] Removed redundant checks, update documentation to remov…

24a73dc

…e reference to utf8mb4

[FLINK-34111] Update scala test

9a60e44

Merge branch 'apache-master' into 34111-jsonquote_unquote

fd9e5a7

[FLINK-34111] Refactor, update comments

0056727

anupamaggarwal mentioned this pull request Jun 20, 2024

[FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function #24156

Closed

[FLINK-34111] Fix spotless warning

3903d24

flinkbot added the component=TableSQL/API label Jun 20, 2024

[FLINK-34111] Add missing function definitions, fix test

48b570f

anupamaggarwal force-pushed the 34111-jsonquote_unquote branch from 2896372 to 48b570f Compare June 20, 2024 15:30

anupamaggarwal marked this pull request as ready for review June 21, 2024 02:38

anupamaggarwal changed the title ~~[FLINK-34111] [table] Add support for json_quote, json_unquote, address PR feedback #24156~~ [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 Jun 21, 2024

[FLINK-34111] Fix java.util.IllegalFormatConversionException in json_…

4267018

…quote(Formatter) due to wrong (char) object type

MartijnVisser requested a review from snuyanzin July 8, 2024 08:36

snuyanzin reviewed Jul 8, 2024

View reviewed changes

snuyanzin requested changes Jul 8, 2024

View reviewed changes

fhueske reviewed Jul 9, 2024

View reviewed changes

[FLINK-34111] CR: Update documentation, add separate function for neg…

141c63e

…ative tests

anupamaggarwal added 2 commits July 10, 2024 16:23

[FLINK-34111] CR: Avoid throwing exception on invalid input

990734b

[FLINK-34111] CR: Add, refactor negative tests

ad3ec47

fhueske requested changes Jul 10, 2024

View reviewed changes

...able-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java Outdated Show resolved Hide resolved

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java Outdated Show resolved Hide resolved

anupamaggarwal force-pushed the 34111-jsonquote_unquote branch from b0637b0 to f8bb3e6 Compare July 11, 2024 05:23

[FLINK-34111] CR: Fix unquote logic, refactor, add tests

04db96e

anupamaggarwal force-pushed the 34111-jsonquote_unquote branch from f8bb3e6 to 04db96e Compare July 11, 2024 07:24

snuyanzin reviewed Jul 11, 2024

View reviewed changes

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java Outdated Show resolved Hide resolved

[FLINK-34111] CR: Rearranging order of methods public to private

ba9ebfa

fhueske reviewed Jul 11, 2024

View reviewed changes

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java Outdated Show resolved Hide resolved

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java Outdated Show resolved Hide resolved

fhueske reviewed Jul 11, 2024

View reviewed changes

[FLINK-34111] CR: Catch only expected exceptions

80b693d

snuyanzin reviewed Jul 11, 2024

View reviewed changes

...ntime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java Outdated Show resolved Hide resolved

[FLINK-34111] CR: Exception handling, add UT

7546d9c

anupamaggarwal force-pushed the 34111-jsonquote_unquote branch from d0cc2cc to 7546d9c Compare July 17, 2024 06:45

[FLINK-34111] CR: Add documentation for json_(un)quote to chinese doc

cbcb044

fhueske approved these changes Aug 6, 2024

View reviewed changes

[FLINK-34111] CR: Update documentation

37fa2e7

snuyanzin approved these changes Aug 7, 2024

View reviewed changes

Merge remote-tracking branch 'oss1/master' into 34111-jsonquote_unquote

570d28f

snuyanzin closed this in 9457b87 Aug 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 #24967

[FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 #24967

anupamaggarwal commented Jun 20, 2024 •

edited

Loading

flinkbot commented Jun 20, 2024 •

edited

Loading

anupamaggarwal commented Jun 20, 2024

snuyanzin commented Jul 4, 2024 •

edited

Loading

anupamaggarwal commented Jul 5, 2024

snuyanzin Jul 8, 2024

fhueske Jul 9, 2024 •

edited

Loading

anupamaggarwal Jul 10, 2024

snuyanzin Jul 11, 2024

anupamaggarwal Jul 17, 2024

snuyanzin left a comment •

edited

Loading

fhueske left a comment

anupamaggarwal commented Jul 10, 2024

snuyanzin commented Jul 10, 2024

fhueske left a comment

fhueske left a comment

fhueske Jul 11, 2024

anupamaggarwal Jul 11, 2024

snuyanzin commented Jul 11, 2024

anupamaggarwal commented Jul 17, 2024

fhueske left a comment

fhueske Aug 6, 2024

anupamaggarwal Aug 7, 2024

snuyanzin commented Aug 7, 2024

snuyanzin commented Aug 7, 2024

anupamaggarwal commented Aug 7, 2024

anupamaggarwal commented Aug 8, 2024 •

edited

Loading

snuyanzin commented Aug 8, 2024

fhueske commented Aug 9, 2024

	description: Unquotes JSON value, unescapes escaped special characters ('"', '\', '/', 'b', 'f', 'n', 'r', 't', 'u' hex hex hex hex), and returns the result as a string. If the argument is NULL, returns NULL. If the value starts and ends with double quotes but is not a valid JSON string literal, the value is passed through unmodified.
	description: Unquotes JSON value, unescapes escaped special characters ('"', '\', '/', 'b', 'f', 'n', 'r', 't', 'u' hex hex hex hex), and returns the result as a string. If the argument is NULL, returns NULL. If the value does not start and ends with double quotes or if it starts and ends with double quotes but is not a valid JSON string literal, the value is passed through unmodified.

[FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 #24967

[FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 #24967

Conversation

anupamaggarwal commented Jun 20, 2024 • edited Loading

What is the purpose of the change

Brief change log / changes compared to PR 24156

Diff compared to #24156 - link

Open questions

References

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Jun 20, 2024 • edited Loading

CI report:

anupamaggarwal commented Jun 20, 2024

snuyanzin commented Jul 4, 2024 • edited Loading

anupamaggarwal commented Jul 5, 2024

Choose a reason for hiding this comment

fhueske Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuyanzin left a comment • edited Loading

Choose a reason for hiding this comment

fhueske left a comment

Choose a reason for hiding this comment

anupamaggarwal commented Jul 10, 2024

snuyanzin commented Jul 10, 2024

fhueske left a comment

Choose a reason for hiding this comment

fhueske left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuyanzin commented Jul 11, 2024

anupamaggarwal commented Jul 17, 2024

fhueske left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuyanzin commented Aug 7, 2024

snuyanzin commented Aug 7, 2024

anupamaggarwal commented Aug 7, 2024

anupamaggarwal commented Aug 8, 2024 • edited Loading

snuyanzin commented Aug 8, 2024

fhueske commented Aug 9, 2024

anupamaggarwal commented Jun 20, 2024 •

edited

Loading

flinkbot commented Jun 20, 2024 •

edited

Loading

snuyanzin commented Jul 4, 2024 •

edited

Loading

fhueske Jul 9, 2024 •

edited

Loading

snuyanzin left a comment •

edited

Loading

anupamaggarwal commented Aug 8, 2024 •

edited

Loading