Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](migrate) Fix iterator returning too early #41168 #41190

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Sep 24, 2024

cherry pick from #41168

introduced in apache#41083.

Because the iterator returns too early, only one piece of data is
returned each time a binlog is obtained for a certain version range.
When the system triggers compaction and generates a rowset that spans
versions, the binlog files copied by the migrate task may be missed.
@w41ter
Copy link
Contributor Author

w41ter commented Sep 24, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (8148/21545)
Line Coverage: 29.56% (67071/226922)
Region Coverage: 29.03% (34573/119106)
Branch Coverage: 24.93% (17808/71426)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1f9faca8970f5d9e7e6685d961b521980f7b83b7_1f9faca8970f5d9e7e6685d961b521980f7b83b7/report/index.html

@w41ter w41ter merged commit c4600e5 into apache:branch-2.0 Sep 24, 2024
20 of 24 checks passed
@w41ter w41ter deleted the pick_41168_to_origin_branch-2.0 branch September 24, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants