-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](function) Optimize the concat(col, constant, constant, constant) function #40670
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 38259 ms
|
TPC-DS: Total hot run time: 197429 ms
|
ClickBench: Total hot run time: 31.59 s
|
run buildall |
efa785e
to
d72b33e
Compare
run buildall |
TeamCity be ut coverage result: |
run performance |
TPC-H: Total hot run time: 38450 ms
|
TPC-DS: Total hot run time: 197582 ms
|
ClickBench: Total hot run time: 31.19 s
|
state->use_state = false; | ||
break; | ||
} | ||
auto string_vale = column_string->column_ptr->get_data_at(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check here is NULL const, what happen
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 43214 ms
|
TPC-DS: Total hot run time: 194930 ms
|
ClickBench: Total hot run time: 31.68 s
|
run external |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes