[Enhancement](be-logger) Support custom date time format functionality in be log. #40347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
kaka11chen
force-pushed
the
be_log_custom_date_time_format_prefix
branch
from
5e78119
to
c46cff4
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
kaka11chen
force-pushed
the
be_log_custom_date_time_format_prefix
branch
from
c46cff4
to
573a67f
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38291 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192727 ms |
ClickBench: Total hot run time: 31.67 s |
|
run compile |
morningman
reviewed
Sep 4, 2024
|
|
||
| // Add a space if custom_date_time_format. | ||
| if constexpr (custom_date_time_format) { | ||
| s << ' '; |
There was a problem hiding this comment.
easy to parse date time
kaka11chen
force-pushed
the
be_log_custom_date_time_format_prefix
branch
from
573a67f
to
8026e44
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
kaka11chen
force-pushed
the
be_log_custom_date_time_format_prefix
branch
from
8026e44
to
40fe19e
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38271 ms |
TPC-DS: Total hot run time: 192834 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.91 s |
kaka11chen
force-pushed
the
be_log_custom_date_time_format_prefix
branch
from
40fe19e
to
9e64706
Compare
|
run buildall |
TPC-H: Total hot run time: 38402 ms |
TPC-DS: Total hot run time: 194078 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.89 s |
|
run compile |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
Sep 6, 2024
kaka11chen
added a commit
to kaka11chen/doris
that referenced
this pull request
Sep 12, 2024
…y in be log. (apache#40347) ## Proposed changes Add these configurations to control it. ``` // log enable custom date time format DEFINE_Bool(sys_log_enable_custom_date_time_format, "false"); // log custom date time format (https://en.cppreference.com/w/cpp/io/manip/put_time) DEFINE_String(sys_log_custom_date_time_format, "%Y-%m-%d %H:%M:%S"); // log custom date time milliseconds format (fmt::format) DEFINE_String(sys_log_custom_date_time_ms_format, ",{:03d}"); ```
kaka11chen
added a commit
to kaka11chen/doris
that referenced
this pull request
Sep 23, 2024
…y in be log. (apache#40347) Add these configurations to control it. ``` // log enable custom date time format DEFINE_Bool(sys_log_enable_custom_date_time_format, "false"); // log custom date time format (https://en.cppreference.com/w/cpp/io/manip/put_time) DEFINE_String(sys_log_custom_date_time_format, "%Y-%m-%d %H:%M:%S"); // log custom date time milliseconds format (fmt::format) DEFINE_String(sys_log_custom_date_time_ms_format, ",{:03d}"); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add these configurations to control it.