Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](multi-catalog) Fix the transaction is not removed in abnormal situations by removing transaction in finally block. #36705

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[Fix](multi-catalog) Fix the transaction is not removed in abnormal situations by removing transaction in finally block. #36705

merged 1 commit into from
Jun 28, 2024

Conversation

kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Jun 22, 2024 •
edited
Loading

Proposed changes

[Fix] (multi-catalog) Fix the transaction is not removed in abnormal situations by removing transaction in finally block.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaka11chen
Copy link
Contributor Author

run buildall

morningman
morningman previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39840 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3944d9891c0b1ccdac888b6981b4663d4630ceb2, data reload: false

------ Round 1 ----------------------------------
q1	17599	4453	4285	4285
q2	2028	192	193	192
q3	10448	1177	1100	1100
q4	10183	833	729	729
q5	7484	2619	2660	2619
q6	220	135	134	134
q7	938	611	596	596
q8	9216	2052	2069	2052
q9	8870	6544	6486	6486
q10	8904	3731	3764	3731
q11	480	251	234	234
q12	484	247	229	229
q13	18897	2946	2983	2946
q14	264	227	227	227
q15	524	478	464	464
q16	520	383	378	378
q17	973	673	702	673
q18	7997	7373	7478	7373
q19	6441	1529	1474	1474
q20	660	317	331	317
q21	4943	3262	3910	3262
q22	399	339	340	339
Total cold run time: 118472 ms
Total hot run time: 39840 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4366	4250	4239	4239
q2	370	260	271	260
q3	3038	2929	2890	2890
q4	1986	1681	1733	1681
q5	5549	5549	5414	5414
q6	218	127	132	127
q7	2273	1908	1874	1874
q8	3259	3467	3429	3429
q9	8712	8768	8745	8745
q10	4171	3706	3807	3706
q11	612	485	491	485
q12	816	633	648	633
q13	16168	3125	3152	3125
q14	317	290	268	268
q15	529	477	508	477
q16	502	424	445	424
q17	1816	1522	1493	1493
q18	8205	8013	7757	7757
q19	1835	1707	1592	1592
q20	2945	1885	1854	1854
q21	7967	4942	4808	4808
q22	656	567	563	563
Total cold run time: 76310 ms
Total hot run time: 55844 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174954 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3944d9891c0b1ccdac888b6981b4663d4630ceb2, data reload: false

query1	938	386	383	383
query2	6437	2481	2345	2345
query3	6637	219	226	219
query4	19449	17469	17236	17236
query5	3554	479	481	479
query6	222	160	163	160
query7	4524	297	289	289
query8	323	304	315	304
query9	8332	2390	2359	2359
query10	556	299	289	289
query11	10532	10090	10157	10090
query12	119	90	87	87
query13	1564	380	374	374
query14	9170	7812	7608	7608
query15	223	188	203	188
query16	7826	284	279	279
query17	1855	573	569	569
query18	1998	273	267	267
query19	210	164	154	154
query20	91	96	84	84
query21	205	132	130	130
query22	4404	4068	4083	4068
query23	34002	33898	33815	33815
query24	10872	2853	2848	2848
query25	628	388	363	363
query26	1146	158	160	158
query27	2309	338	322	322
query28	6814	2143	2140	2140
query29	908	639	627	627
query30	235	153	160	153
query31	933	779	772	772
query32	90	53	55	53
query33	756	304	278	278
query34	1041	480	495	480
query35	766	651	626	626
query36	1092	981	996	981
query37	150	77	73	73
query38	2930	2823	2840	2823
query39	900	825	823	823
query40	203	143	144	143
query41	55	52	57	52
query42	109	105	110	105
query43	621	545	547	545
query44	1187	744	740	740
query45	190	166	161	161
query46	1074	743	741	741
query47	1913	1792	1804	1792
query48	386	301	295	295
query49	845	436	407	407
query50	786	400	409	400
query51	6947	6791	6774	6774
query52	111	91	92	91
query53	356	298	290	290
query54	813	455	444	444
query55	75	72	77	72
query56	282	261	260	260
query57	1101	1044	1092	1044
query58	247	248	248	248
query59	3386	3212	3116	3116
query60	284	278	294	278
query61	111	94	93	93
query62	595	440	438	438
query63	312	289	288	288
query64	8685	2245	1763	1763
query65	3240	3103	3149	3103
query66	749	338	331	331
query67	16434	15307	14888	14888
query68	5589	535	564	535
query69	582	494	434	434
query70	1185	1173	1120	1120
query71	472	277	273	273
query72	7215	5293	5210	5210
query73	773	345	334	334
query74	5893	5521	5393	5393
query75	3879	2628	2691	2628
query76	3627	973	933	933
query77	609	295	307	295
query78	10420	10009	9736	9736
query79	1472	530	547	530
query80	2061	502	492	492
query81	580	220	221	220
query82	714	109	108	108
query83	310	175	170	170
query84	263	90	89	89
query85	1284	307	283	283
query86	462	329	339	329
query87	3314	3086	3075	3075
query88	3691	2486	2473	2473
query89	492	385	392	385
query90	1717	201	194	194
query91	136	103	102	102
query92	60	52	56	52
query93	2105	512	517	512
query94	1064	192	190	190
query95	409	319	321	319
query96	606	284	273	273
query97	3227	3022	3046	3022
query98	225	207	265	207
query99	1196	860	840	840
Total cold run time: 271470 ms
Total hot run time: 174954 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.18 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3944d9891c0b1ccdac888b6981b4663d4630ceb2, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.09
query5	0.50	0.49	0.48
query6	1.14	0.74	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.54	0.55	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.13
query13	0.60	0.59	0.61
query14	0.79	0.77	0.78
query15	0.85	0.81	0.82
query16	0.37	0.36	0.36
query17	1.02	1.02	1.02
query18	0.23	0.24	0.26
query19	1.84	1.74	1.70
query20	0.02	0.01	0.02
query21	15.44	0.66	0.65
query22	4.31	7.91	1.39
query23	18.23	1.39	1.34
query24	2.15	0.23	0.21
query25	0.15	0.09	0.08
query26	0.27	0.18	0.17
query27	0.09	0.08	0.08
query28	13.23	1.03	0.99
query29	12.61	3.32	3.29
query30	0.26	0.07	0.06
query31	2.84	0.38	0.39
query32	3.27	0.47	0.47
query33	2.87	2.83	2.90
query34	17.36	4.51	4.43
query35	4.55	4.51	4.55
query36	0.66	0.46	0.46
query37	0.19	0.16	0.15
query38	0.15	0.16	0.15
query39	0.04	0.04	0.04
query40	0.18	0.14	0.14
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.86 s
Total hot run time: 30.18 s

@kaka11chen kaka11chen changed the title [Fix](multi-catalog) Fix the transaction is not removed in abnormal situations by removing transaction firstly. [Fix](multi-catalog) Fix the transaction is not removed in abnormal situations by removing transaction in finally block. Jun 24, 2024
@kaka11chen
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 40144 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e0417ab33c5e51b64acbe922a96e15fdcd29e44, data reload: false

------ Round 1 ----------------------------------
q1	17611	4309	4247	4247
q2	2011	192	187	187
q3	10480	1123	1076	1076
q4	10188	791	749	749
q5	7430	2641	2606	2606
q6	216	131	131	131
q7	930	605	600	600
q8	9243	2070	2021	2021
q9	8763	6491	6430	6430
q10	9066	3705	3749	3705
q11	454	242	231	231
q12	449	220	224	220
q13	18775	2948	2948	2948
q14	260	215	217	215
q15	520	468	480	468
q16	509	373	377	373
q17	938	630	662	630
q18	7969	7479	7365	7365
q19	5186	1485	1487	1485
q20	647	323	321	321
q21	4803	3798	3904	3798
q22	407	338	339	338
Total cold run time: 116855 ms
Total hot run time: 40144 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4426	4215	4268	4215
q2	371	275	271	271
q3	2999	2878	2825	2825
q4	1942	1700	1654	1654
q5	5590	5456	5495	5456
q6	219	129	129	129
q7	2168	1875	1823	1823
q8	3322	3421	3432	3421
q9	8745	8722	8749	8722
q10	4050	3874	3716	3716
q11	620	507	490	490
q12	812	658	593	593
q13	15978	3145	3141	3141
q14	301	273	284	273
q15	520	493	500	493
q16	474	418	433	418
q17	1803	1526	1503	1503
q18	8242	7891	7815	7815
q19	1788	1628	1654	1628
q20	3038	1957	1895	1895
q21	8521	4826	4852	4826
q22	632	527	536	527
Total cold run time: 76561 ms
Total hot run time: 55834 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174100 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e0417ab33c5e51b64acbe922a96e15fdcd29e44, data reload: false

query1	921	388	361	361
query2	6424	2322	2345	2322
query3	6619	213	210	210
query4	20775	17366	17409	17366
query5	3609	465	488	465
query6	275	170	164	164
query7	4561	293	286	286
query8	312	296	279	279
query9	8348	2390	2358	2358
query10	564	291	269	269
query11	10552	10029	9937	9937
query12	111	91	79	79
query13	1594	381	385	381
query14	8465	6987	7506	6987
query15	224	185	183	183
query16	7958	276	281	276
query17	2216	548	546	546
query18	2008	277	273	273
query19	199	154	162	154
query20	90	86	84	84
query21	204	127	123	123
query22	4805	4134	4059	4059
query23	33781	33544	33626	33544
query24	10917	2922	2910	2910
query25	622	389	376	376
query26	1204	157	154	154
query27	2417	330	332	330
query28	7440	2122	2112	2112
query29	904	631	651	631
query30	228	157	154	154
query31	1000	767	729	729
query32	92	54	63	54
query33	736	289	301	289
query34	1007	492	487	487
query35	775	640	630	630
query36	1163	1035	974	974
query37	136	74	75	74
query38	2988	2820	2783	2783
query39	892	854	852	852
query40	212	133	128	128
query41	56	56	53	53
query42	121	97	106	97
query43	592	567	541	541
query44	1272	752	742	742
query45	193	160	170	160
query46	1087	763	733	733
query47	1850	1787	1748	1748
query48	378	303	305	303
query49	875	423	434	423
query50	768	392	405	392
query51	6832	6829	6786	6786
query52	106	95	95	95
query53	364	290	292	290
query54	845	458	450	450
query55	78	78	76	76
query56	295	278	277	277
query57	1091	1067	1043	1043
query58	264	264	248	248
query59	3538	3233	3153	3153
query60	307	292	305	292
query61	114	107	113	107
query62	599	447	450	447
query63	317	287	292	287
query64	8819	2324	1754	1754
query65	3124	3085	3085	3085
query66	741	329	323	323
query67	15534	14997	14979	14979
query68	4572	536	549	536
query69	616	389	373	373
query70	1180	1137	1171	1137
query71	461	269	268	268
query72	8836	5756	5537	5537
query73	736	335	331	331
query74	5975	5507	5485	5485
query75	4078	2658	2678	2658
query76	3016	912	902	902
query77	690	310	304	304
query78	10562	9879	9629	9629
query79	2536	528	508	508
query80	1162	475	462	462
query81	555	228	219	219
query82	1003	108	106	106
query83	386	167	165	165
query84	270	90	87	87
query85	1899	287	274	274
query86	463	337	310	310
query87	3315	3104	3098	3098
query88	4378	2458	2443	2443
query89	466	380	379	379
query90	1841	183	185	183
query91	128	99	158	99
query92	60	48	46	46
query93	2615	506	499	499
query94	1203	188	185	185
query95	407	322	314	314
query96	597	272	273	272
query97	3231	3006	3084	3006
query98	224	198	196	196
query99	1167	851	832	832
Total cold run time: 276136 ms
Total hot run time: 174100 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e0417ab33c5e51b64acbe922a96e15fdcd29e44, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.22	0.05	0.04
query4	1.69	0.07	0.06
query5	0.47	0.48	0.58
query6	1.14	0.72	0.71
query7	0.01	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.53	0.53	0.53
query11	0.14	0.11	0.11
query12	0.15	0.12	0.13
query13	0.59	0.59	0.58
query14	0.76	0.79	0.80
query15	0.83	0.80	0.80
query16	0.36	0.34	0.36
query17	0.96	0.97	0.96
query18	0.22	0.24	0.25
query19	1.79	1.71	1.70
query20	0.01	0.01	0.01
query21	15.41	0.66	0.67
query22	4.69	7.24	2.37
query23	18.59	1.35	1.20
query24	2.13	0.22	0.22
query25	0.15	0.08	0.08
query26	0.26	0.17	0.17
query27	0.08	0.08	0.08
query28	13.25	1.03	1.01
query29	12.57	3.44	3.38
query30	0.26	0.07	0.06
query31	2.87	0.40	0.38
query32	3.27	0.47	0.47
query33	2.88	2.93	2.93
query34	17.17	4.43	4.39
query35	4.49	4.46	4.50
query36	0.66	0.46	0.47
query37	0.19	0.16	0.15
query38	0.14	0.14	0.15
query39	0.04	0.04	0.04
query40	0.18	0.14	0.14
query41	0.11	0.05	0.04
query42	0.05	0.04	0.06
query43	0.05	0.05	0.04
Total cold run time: 110.06 s
Total hot run time: 30.97 s

@kaka11chen
[Fix](multi-catalog) Fix the transaction is not removed in abnormal s…
9e02519 
…ituations by removing transaction in finally block.
@kaka11chen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39838 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e025199c655504e39dd7e3cba6f06e5eb9737ed, data reload: false

------ Round 1 ----------------------------------
q1	18029	4452	4381	4381
q2	2596	193	184	184
q3	11077	1115	1209	1115
q4	10601	841	795	795
q5	7800	2681	2691	2681
q6	226	137	134	134
q7	947	610	616	610
q8	9498	2084	2068	2068
q9	8959	6490	6464	6464
q10	8940	3734	3731	3731
q11	453	241	235	235
q12	430	226	226	226
q13	18217	2995	2998	2995
q14	278	223	235	223
q15	519	473	478	473
q16	560	376	385	376
q17	967	708	660	660
q18	7967	7463	7297	7297
q19	3049	1550	1503	1503
q20	639	306	323	306
q21	4899	3048	3874	3048
q22	387	333	339	333
Total cold run time: 117038 ms
Total hot run time: 39838 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4442	4254	4202	4202
q2	370	259	265	259
q3	2942	2775	2705	2705
q4	1854	1580	1652	1580
q5	5239	5211	5266	5211
q6	210	129	127	127
q7	2088	1701	1774	1701
q8	3187	3295	3286	3286
q9	8351	8299	8288	8288
q10	3862	3674	3700	3674
q11	595	481	494	481
q12	796	620	595	595
q13	16226	3028	2984	2984
q14	285	253	263	253
q15	514	482	481	481
q16	471	408	405	405
q17	1763	1466	1448	1448
q18	7698	7572	7387	7387
q19	1644	1657	1483	1483
q20	2010	1780	1780	1780
q21	4845	4666	4735	4666
q22	615	553	561	553
Total cold run time: 70007 ms
Total hot run time: 53549 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172291 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e025199c655504e39dd7e3cba6f06e5eb9737ed, data reload: false

query1	949	372	365	365
query2	6436	2288	2242	2242
query3	6651	203	201	201
query4	19957	17187	17236	17187
query5	4136	465	455	455
query6	244	158	162	158
query7	4591	303	289	289
query8	311	284	278	278
query9	8762	2385	2348	2348
query10	609	311	291	291
query11	10833	10074	10000	10000
query12	131	80	82	80
query13	1635	379	365	365
query14	9489	6866	6413	6413
query15	223	191	190	190
query16	7812	274	271	271
query17	1649	566	550	550
query18	1956	290	283	283
query19	205	159	171	159
query20	93	89	88	88
query21	210	134	140	134
query22	4440	3964	4031	3964
query23	33709	33254	33268	33254
query24	11279	2828	2928	2828
query25	666	378	386	378
query26	1564	158	156	156
query27	2986	316	316	316
query28	7234	2070	2070	2070
query29	1030	630	627	627
query30	272	154	154	154
query31	959	709	748	709
query32	89	54	58	54
query33	803	304	293	293
query34	960	458	471	458
query35	774	640	611	611
query36	1119	922	921	921
query37	144	70	74	70
query38	2906	2744	2742	2742
query39	845	794	808	794
query40	264	134	131	131
query41	55	54	54	54
query42	123	100	96	96
query43	572	547	535	535
query44	1175	720	735	720
query45	200	164	166	164
query46	1087	699	722	699
query47	1866	1832	1795	1795
query48	378	307	302	302
query49	1159	417	417	417
query50	759	384	386	384
query51	6884	6821	6835	6821
query52	107	93	95	93
query53	353	296	293	293
query54	914	458	448	448
query55	81	72	75	72
query56	310	278	277	277
query57	1177	1097	1057	1057
query58	266	243	261	243
query59	3355	3102	3191	3102
query60	318	296	295	295
query61	112	110	119	110
query62	652	465	565	465
query63	314	293	297	293
query64	9713	2219	1765	1765
query65	3400	3115	3098	3098
query66	1368	340	327	327
query67	15686	14963	14856	14856
query68	8770	542	536	536
query69	690	475	402	402
query70	1388	1094	1118	1094
query71	537	297	273	273
query72	8999	5655	5133	5133
query73	2282	325	322	322
query74	5890	5572	5525	5525
query75	5436	2659	2683	2659
query76	5206	952	869	869
query77	775	314	302	302
query78	10563	9972	9878	9878
query79	7462	513	513	513
query80	2301	509	472	472
query81	571	227	219	219
query82	486	106	103	103
query83	297	167	169	167
query84	266	85	87	85
query85	1040	286	265	265
query86	384	313	314	313
query87	3282	3100	3174	3100
query88	4553	2341	2347	2341
query89	514	385	392	385
query90	2067	191	225	191
query91	132	98	98	98
query92	68	52	51	51
query93	5430	513	503	503
query94	1355	189	188	188
query95	402	316	311	311
query96	612	264	264	264
query97	3264	3055	3032	3032
query98	210	201	192	192
query99	1156	848	847	847
Total cold run time: 297697 ms
Total hot run time: 172291 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e025199c655504e39dd7e3cba6f06e5eb9737ed, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.22	0.04	0.04
query4	1.68	0.08	0.08
query5	0.50	0.52	0.50
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.54	0.48	0.50
query10	0.52	0.54	0.53
query11	0.14	0.11	0.11
query12	0.14	0.12	0.11
query13	0.60	0.58	0.58
query14	0.77	0.78	0.80
query15	0.84	0.80	0.81
query16	0.37	0.36	0.36
query17	1.00	1.02	1.05
query18	0.23	0.25	0.24
query19	1.87	1.79	1.81
query20	0.02	0.01	0.01
query21	15.43	0.68	0.66
query22	4.12	7.00	2.23
query23	18.24	1.33	1.18
query24	2.08	0.24	0.22
query25	0.14	0.09	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.09
query28	13.16	1.03	1.01
query29	12.57	3.27	3.28
query30	0.25	0.05	0.06
query31	2.88	0.38	0.38
query32	3.26	0.48	0.47
query33	2.94	2.88	2.91
query34	17.27	4.47	4.51
query35	4.55	4.49	4.50
query36	0.66	0.47	0.46
query37	0.18	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.16	0.14	0.13
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.37 s
Total hot run time: 30.95 s

morningman
morningman approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit a2ee53a into apache:master Jun 28, 2024
26 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jun 30, 2024
@kaka11chen @dataroaring
[Fix](multi-catalog) Fix the transaction is not removed in abnormal s…
05f694a 
…ituations by removing transaction in finally block. (#36705)

[Fix] (multi-catalog) Fix the transaction is not removed in abnormal
situations by removing transaction in `finally` block.
kaka11chen added a commit to kaka11chen/doris that referenced this pull request Jul 2, 2024
@kaka11chen
[Fix](multi-catalog) Fix the transaction is not removed in abnormal s…
2fe7ea4 
…ituations by removing transaction in finally block. (apache#36705)

[Fix] (multi-catalog) Fix the transaction is not removed in abnormal
situations by removing transaction in `finally` block.
@kaka11chen kaka11chen mentioned this pull request Jul 2, 2024
Merged
morningman pushed a commit that referenced this pull request Jul 3, 2024
@kaka11chen
[Fix](multi-catalog) Fix the transaction is not removed in abnormal s…
17056dc 
…ituations by removing transaction in finally block. (#37172)

Backport #36705.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaka11chen @doris-robot @morningman @wuwenchi @dataroaring