[Fix](hive-writer) Fix crash when hive partition writer building partition update. #35311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| Status VHivePartitionWriter::_open_internal(RuntimeState* state, RuntimeProfile* profile) { |
There was a problem hiding this comment.
warning: function '_open_internal' exceeds recommended size/complexity thresholds [readability-function-size]
Status VHivePartitionWriter::_open_internal(RuntimeState* state, RuntimeProfile* profile) {
^Additional context
be/src/vec/sink/writer/vhive_partition_writer.cpp:65: 94 lines including whitespace and comments (threshold 80)
Status VHivePartitionWriter::_open_internal(RuntimeState* state, RuntimeProfile* profile) {
^
kaka11chen
changed the title
kaka11chen
force-pushed
the
fix_hive_writer_core
branch
from
955ecd6
to
e24fd30
Compare
|
run buildall |
TPC-H: Total hot run time: 39869 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 169482 ms |
ClickBench: Total hot run time: 31.11 s |
kaka11chen
force-pushed
the
fix_hive_writer_core
branch
2 times, most recently
from
7602eb9
to
e9b42ed
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
kaka11chen
force-pushed
the
fix_hive_writer_core
branch
from
e9b42ed
to
f747df6
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39987 ms |
TPC-DS: Total hot run time: 171542 ms |
ClickBench: Total hot run time: 31.7 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
May 26, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 27, 2024
Issue: #31442 ``` /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007F963FA9D090 in /lib/x86_64-linux-gnu/libc.so.6 4# doris::vectorized::VHivePartitionWriter::_build_partition_update() at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_partition_writer.cpp:215 5# doris::vectorized::VHivePartitionWriter::close(doris::Status const&) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_partition_writer.cpp:164 6# doris::vectorized::VHiveTableWriter::close(doris::Status) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_table_writer.cpp:209 7# doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/async_result_writer.cpp:184 8# doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const at ```
yiguolei
pushed a commit
that referenced
this pull request
May 27, 2024
Issue: #31442 ``` /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007F963FA9D090 in /lib/x86_64-linux-gnu/libc.so.6 4# doris::vectorized::VHivePartitionWriter::_build_partition_update() at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_partition_writer.cpp:215 5# doris::vectorized::VHivePartitionWriter::close(doris::Status const&) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_partition_writer.cpp:164 6# doris::vectorized::VHiveTableWriter::close(doris::Status) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_table_writer.cpp:209 7# doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/async_result_writer.cpp:184 8# doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const at ```
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
May 27, 2024
Issue: apache#31442 ``` /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so 3# 0x00007F963FA9D090 in /lib/x86_64-linux-gnu/libc.so.6 4# doris::vectorized::VHivePartitionWriter::_build_partition_update() at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_partition_writer.cpp:215 5# doris::vectorized::VHivePartitionWriter::close(doris::Status const&) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_partition_writer.cpp:164 6# doris::vectorized::VHiveTableWriter::close(doris::Status) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vhive_table_writer.cpp:209 7# doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/async_result_writer.cpp:184 8# doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const at ```
morningman
pushed a commit
that referenced
this pull request
May 29, 2024
### Issue `The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)` ### Root cause #35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly. ### Solution Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
May 29, 2024
### Issue `The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)` ### Root cause apache#35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly. ### Solution Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
### Issue `The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: S3, Status Code: 404, Request ID: 66557027E897233333FFC198)` ### Root cause #35311 adjusted the order of building hive partition update information. This change caused the update id to be unable to be obtained, causing the s3 file committer to not work properly. ### Solution Because uploading to s3 occurs after s3 file writer close(), close() must be called first, and then the build hive partiton update information is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue: #31442
Root cause
Building hive partition update information use
_file_format_transformer->written_len(), but _file_format_transformer will be nullptr when hivePartitionWriteropen()failed (return error status).Solution
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...