Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test](hive-writer) Adjust test_hive_write_partitions regression test to resolve special characters issue with git on windows. #34026

Merged

Conversation

kaka11chen
Copy link
Contributor

Proposed changes

[Test] (hive-writer) Adjust test_hive_write_partitions regression test to resolve special characters issue with git on windows.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaka11chen kaka11chen force-pushed the adjust_test_hive_write_partitions branch from e70cdfc to 0a72419 Compare April 23, 2024 10:10
@kaka11chen
Copy link
Contributor Author

run buildall

1 similar comment
@kaka11chen
Copy link
Contributor Author

run buildall

@kaka11chen
Copy link
Contributor Author

run external

1 similar comment
@kaka11chen
Copy link
Contributor Author

run external

@kaka11chen kaka11chen force-pushed the adjust_test_hive_write_partitions branch from a85a15a to 94289fe Compare April 24, 2024 07:35
@kaka11chen
Copy link
Contributor Author

run buildall

@morningman morningman force-pushed the adjust_test_hive_write_partitions branch from 94289fe to 4f91699 Compare April 25, 2024 12:03
@morningman
Copy link
Contributor

run buildall

… to resolve github checkout special characters issue on windows.
@kaka11chen kaka11chen force-pushed the adjust_test_hive_write_partitions branch from 4f91699 to bd1cb3b Compare April 25, 2024 19:18
@kaka11chen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 26, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit fcc7e07 into apache:master Apr 26, 2024
26 of 28 checks passed
yiguolei pushed a commit that referenced this pull request Apr 26, 2024
… to resolve special characters issue with git on windows. (#34026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants