-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement](data-type) add FE config to prohibit create date and decimalv2 type #19077
Conversation
run buildall |
TeamCity pipeline, clickbench performance test result: |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…cimalv2 type (apache#19077) * prohibits date and decimal type * add config in test
…cimalv2 type (apache#19077) * prohibits date and decimal type * add config in test
…19247) This PR enables periodic collection of statistics and is a precursor to automatic statistics collection. It mainly includes the following contents: support periodic collection of statistics. Change the type of Date in statistics p0 to DateV2(see [Enhancement](data-type) add FE config to prohibit create date and decimalv2 type #19077) for test locally. complement cases(remove Chinese characters, optimize code, etc) , improve stability. Supports setting whether to keep records of statistics synchronization job info, convenient for use in p0 testing. The statistics job table was modified, and some auxiliary judgments were added to avoid the user perceiving the modification. This function was removed when the table schema is stable.
…cimalv2 type (apache#19077) * prohibits date and decimal type * add config in test
…pache#19247) This PR enables periodic collection of statistics and is a precursor to automatic statistics collection. It mainly includes the following contents: support periodic collection of statistics. Change the type of Date in statistics p0 to DateV2(see [Enhancement](data-type) add FE config to prohibit create date and decimalv2 type apache#19077) for test locally. complement cases(remove Chinese characters, optimize code, etc) , improve stability. Supports setting whether to keep records of statistics synchronization job info, convenient for use in p0 testing. The statistics job table was modified, and some auxiliary judgments were added to avoid the user perceiving the modification. This function was removed when the table schema is stable.
Proposed changes
Issue Number: close #xxx
Problem summary
FE config
disable_decimalv2
, default is true.disable_datev1
, default is true.Afterwards, Doris prohibits creating tables containing the
DATE
andDECIMAL
type by default.Because of intending to delete these types in the future. At this stage, If you need to use these types, you need to add
disable_datev1 = false
ordisable_decimalv2 = false
in the FE's config and restart the FE.On regression pipeline, these parameters in FE config is set false.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...