-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Optimize](parquet-reader) Add has_filter
template param in get_next_run()
to decrease _has_filter
condition checking count in the loop.
#19043
[Optimize](parquet-reader) Add has_filter
template param in get_next_run()
to decrease _has_filter
condition checking count in the loop.
#19043
Conversation
…ease `_has_filter` condition checking count in the loop.`
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ease `_has_filter` condition checking count in the loop.` (apache#19043)
Proposed changes
Problem summary
In
XXXDecoder::decode_values():
It will call
get_next_run()
, need to check_has_filter
in the loop.It is unnecessary. So optimize it by adding
has_filter
template param inget_next_run()
to decrease_has_filter
condition checking count in the loop.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...