Fix job hangs when partition count of plan is zero #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lewiszlw. Could you rebase/upmerge (to fix the CI failure) then I can review |
andygrove
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When partition count of execution plan is 0, the job will hang because available tasks of running stage will be empty, then
get_running_stage_idmethod ofExecutionGraphwill return None.datafusion-ballista/ballista/scheduler/src/state/execution_graph.rs
Line 969 in e7cb3d5
So the running stage will keep running and won't be converted to successful/failed stage.
What changes are included in this PR?
Are there any user-facing changes?