Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky StreamingDataflowWorkerTest which wasn't waiting for enough commits #31781

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

scwhittle
Copy link
Contributor

The test waited for 1 commit but expected and validated the 2 commits.
It would pass if both commits happened to be present and fail otherwise.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.19%. Comparing base (a1a2283) to head (4ae560d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #31781   +/-   ##
=========================================
  Coverage     71.19%   71.19%           
  Complexity     3019     3019           
=========================================
  Files          1058     1058           
  Lines        134159   134159           
  Branches       3257     3257           
=========================================
  Hits          95521    95521           
  Misses        35500    35500           
  Partials       3138     3138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scwhittle scwhittle merged commit a5eee58 into apache:master Jul 4, 2024
20 checks passed
@scwhittle scwhittle deleted the fix_flake branch July 4, 2024 20:21
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant