Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SnakeYaml dependency #31512

Closed
wants to merge 6 commits into from

Conversation

ahmedabu98
Copy link
Contributor

SnakeYaml dependency was introduced in #30808 but it led to conflicts with the existing jackson YAML dependency (see #31405 and #26743 (comment))

@github-actions github-actions bot added the java label Jun 5, 2024
@ahmedabu98
Copy link
Contributor Author

R: @chamikaramj
R: @Abacn
R: @kennknowles

@ahmedabu98 ahmedabu98 added this to the 2.57.0 Release milestone Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor

Abacn commented Jun 5, 2024

This is motivated by breaking change of jackson-databind 2.15.x. Can we revert #31473 at the moment also.

@chamikaramj
Copy link
Contributor

I don't think we should revert. #31405 was already fixed.

@github-actions github-actions bot removed the docker label Jun 5, 2024
@github-actions github-actions bot removed the hadoop label Jun 5, 2024
@kennknowles
Copy link
Member

Should this be closed, then? And not blocking 2.57.0?

@ahmedabu98 ahmedabu98 removed this from the 2.57.0 Release milestone Jun 11, 2024
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 11, 2024
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants