Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow to customize wakatime data range #874

Merged
merged 3 commits into from
Mar 8, 2021
Merged

chore: allow to customize wakatime data range #874

merged 3 commits into from
Mar 8, 2021

Conversation

muety
Copy link
Contributor

@muety muety commented Feb 12, 2021

PR #871 changed the WakaTime fetcher in a way that it always requests data for whatever range the user has set as "Default Range" in WakaTime. However, chances are that a user may want a deviating range for her readme cards. Or she wants different ranges for different readmes in different repos.

Also, it makes behavior more predictable when using third-party sevice like Wakapi, that don't have inherent support for configurable "default ranges".

This PR allows to pass another, optional parameter to the WakaTime card to explicitly request a certain range.

@vercel
Copy link

vercel bot commented Feb 12, 2021

@muety is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #874 (76262fe) into master (922f716) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #874   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files          22       22           
  Lines         681      682    +1     
  Branches      190      191    +1     
=======================================
+ Hits          640      641    +1     
  Misses         37       37           
  Partials        4        4           
Impacted Files Coverage Δ
src/fetchers/wakatime-fetcher.js 90.90% <100.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922f716...76262fe. Read the comment docs.

@muety
Copy link
Contributor Author

muety commented Feb 21, 2021

Could somebody please take a look at this?

@anuraghazra
Copy link
Owner

This looks good @muety can you add the range param to docs?

docs: add wakatime section to german readme
@github-actions github-actions bot added the doc-translation README doc translations. label Mar 7, 2021
@muety
Copy link
Contributor Author

muety commented Mar 7, 2021

Sure, it's done!

@muety
Copy link
Contributor Author

muety commented Mar 7, 2021

Btw, how am I supposed to resolve the merge conflict? Rebase onto master or merge it into my feature branch?

@vercel
Copy link

vercel bot commented Mar 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/github-readme-stats-team/github-readme-stats/Be7dfCF1ZYvJWxLeeye2tEZhcYxf
✅ Preview: https://github-readme-git-fork-muety-muety-customize-wakatime-r-f11234.vercel.app

@anuraghazra
Copy link
Owner

This looks good! thanks @muety

@anuraghazra anuraghazra merged commit 24e5f86 into anuraghazra:master Mar 8, 2021
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
* chore: allow to customize wakatime data range

* docs: document wakatime range parameter
docs: add wakatime section to german readme

Co-authored-by: Anurag Hazra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-translation README doc translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants