add corner rounding parameter so we can make square cards #845
Conversation
|
@tcheinen is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
+ Coverage 93.96% 93.97% +0.01%
==========================================
Files 22 22
Lines 679 681 +2
Branches 189 190 +1
==========================================
+ Hits 638 640 +2
Misses 37 37
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Many thanks for the contribution, @tcheinen, I just have one thing that I think could be tweaked. As you can see here, all the parameters are pretty memorable and easily self-explainable. I think it would be better to name it something like border_radius or rounding.
|
makes sense! I renamed it to border_radius |
|
This looks great @tcheinen sorry for the delay. |
…aghazra#845) * add corner rounding parameter so i can make square cards * rename rx to border_radius
…aghazra#845) * add corner rounding parameter so i can make square cards * rename rx to border_radius
Cards are rounded by default which looks kinda ugly when you have two adjacent cards with a dark theme and a light background. I added support for a parameter which allows users to control the rounding used by the card (and had it default to the original 4.5). I added implementation, tests, and readme docs but feel free to ping me if I missed anything.