Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve adjust apply #77

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

yangwenmai
Copy link
Contributor

Benchmark Result

$ go test -run=apply_test.go -benchtime=1s -bench=^BenchmarkApply -cpuprofile=cpu.out -benchmem -memprofile=mem.out -trace trace.out -count=5 > old.txt
$ go test -run=apply_test.go -benchtime=1s -bench=^BenchmarkApply -cpuprofile=cpu.out -benchmem -memprofile=mem.out -trace trace.out -count=5 > new.txt

benchcmp old.txt new.txt Result:

benchmark                 old ns/op     new ns/op     delta
BenchmarkApply-8          216           208           -3.70%
BenchmarkApply-8          216           208           -3.70%
BenchmarkApply-8          216           207           -4.17%
BenchmarkApply-8          215           209           -2.79%
BenchmarkApply-8          216           210           -2.78%

benchmark                 old allocs     new allocs     delta
BenchmarkApply-8          3              3              +0.00%
BenchmarkApply-8          3              3              +0.00%
BenchmarkApply-8          3              3              +0.00%
BenchmarkApply-8          3              3              +0.00%
BenchmarkApply-8          3              3              +0.00%

benchmark                 old bytes     new bytes     delta
BenchmarkApply-8          112           112           +0.00%
BenchmarkApply-8          112           112           +0.00%
BenchmarkApply-8          112           112           +0.00%
BenchmarkApply-8          112           112           +0.00%
BenchmarkApply-8          112           112           +0.00%

@yangwenmai
Copy link
Contributor Author

@anthonynsimon poke

@anthonynsimon
Copy link
Owner

Looks good! Thank you :)

@anthonynsimon anthonynsimon merged commit c7da305 into anthonynsimon:master Feb 4, 2020
@yangwenmai yangwenmai deleted the improve_adjust_apply branch November 24, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants