Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

add onMenuHeaderClick props #74

Merged
merged 3 commits into from
Aug 6, 2019
Merged

add onMenuHeaderClick props #74

merged 3 commits into from
Aug 6, 2019

Conversation

chenshuai2144
Copy link
Collaborator

@chenshuai2144 chenshuai2144 commented Aug 1, 2019

close #69
close #64
close #78

@afc163
Copy link
Member

afc163 commented Aug 1, 2019

这个区域的交互有问题:

image

  • 点击左上角应该返回首页 /,目前没反应。(v2 版本是可以的)
  • 默认应该用 Link 包裹,目前 hover 上去,浏览器左下角没有链接展示。
  • 这个 PR 应该提供整个区域的自定义 render,类似 renderLogoAndTitle({ logo, title }) => ReactNode,这样用户可以传入 Link 或者自定义的 a 外部链接。

@chenshuai2144 chenshuai2144 merged commit 4cea2bc into master Aug 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-onMenuHeaderClick branch August 6, 2019 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants