Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Get variables with "sweep" enabled #5230

Merged
merged 14 commits into from
Oct 4, 2024
Merged

FIX: Get variables with "sweep" enabled #5230

merged 14 commits into from
Oct 4, 2024

Conversation

gmalinve
Copy link
Collaborator

@gmalinve gmalinve commented Oct 1, 2024

No description provided.

@gmalinve gmalinve self-assigned this Oct 1, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Oct 1, 2024
@gmalinve gmalinve linked an issue Oct 1, 2024 that may be closed by this pull request
export_field_file() fails when default variation_dict is used, and some design variables have "sweep" disabled #4382
Closed
2 tasks
@gmalinve gmalinve changed the title Get variables with "sweep" enabled FIX: Get variables with "sweep" enabled Oct 1, 2024
@gmalinve gmalinve marked this pull request as ready for review October 1, 2024 15:31
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (aabca8b) to head (2acfa35).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5230      +/-   ##
==========================================
- Coverage   83.25%   83.25%   -0.01%     
==========================================
  Files         142      142              
  Lines       58221    58237      +16     
==========================================
+ Hits        48473    48485      +12     
- Misses       9748     9752       +4

@gmalinve gmalinve merged commit d5e74a9 into main Oct 4, 2024
43 checks passed
@gmalinve gmalinve deleted the fix/sweep_variables branch October 4, 2024 12:43
@gmalinve gmalinve mentioned this pull request Oct 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees

@gmalinve gmalinve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export_field_file() fails when default variation_dict is used, and some design variables have "sweep" disabled
2 participants
@gmalinve @Samuelopez-ansys