Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Trigger workflow on ready for review event #5224

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Sep 30, 2024

Setup pull request types to allow triggering testings workflows when moving from draft to ready for review

Close #5223

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review September 30, 2024 07:23
@github-actions github-actions bot added the maintenance Package and maintenance related label Sep 30, 2024
@SMoraisAnsys SMoraisAnsys marked this pull request as draft September 30, 2024 07:50
@SMoraisAnsys SMoraisAnsys changed the title TBR: Log github info CI: Trigger workflow on ready for review event Sep 30, 2024
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review September 30, 2024 08:12
@SMoraisAnsys
Copy link
Collaborator Author

Before clicking on ready for review the PR was not running the tests as expected.

image

Clicking on ready for review did trigger the whole workflow again. Hopefully the skipped tests should be running now.

@SMoraisAnsys
Copy link
Collaborator Author

The jobs are running as expected

image

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (e6280c7) to head (b072e33).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5224      +/-   ##
==========================================
- Coverage   83.35%   83.25%   -0.10%     
==========================================
  Files         142      142              
  Lines       58201    58221      +20     
==========================================
- Hits        48514    48474      -40     
- Misses       9687     9747      +60     

@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) October 3, 2024 09:24
@SMoraisAnsys SMoraisAnsys merged commit aabca8b into main Oct 3, 2024
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/fix-draft-skipping branch October 3, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: The draft approach does not trigger back testing when PR is ready for review
3 participants