Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure_rm_availabilityset: fix checkmode support #627

Merged
merged 4 commits into from
Feb 11, 2022
Merged

azure_rm_availabilityset: fix checkmode support #627

merged 4 commits into from
Feb 11, 2022

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Sep 2, 2021

SUMMARY
  • Fix "changed" status in check_mode when creating / updating resource (changed used to always return "false", now it returns true if resources need to be created / updated).
  • Fix check_mode for state: absent: currently it does NOT respect check_mode if state is absent. As a result, the resource will get deleted even in check_mode.
  • Fix state: absent always returning changed: true even if no resource was deleted.

Several new integration tests have been added to validate these cases.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • azure_rm_availabilityset

@nbr23 nbr23 marked this pull request as ready for review September 2, 2021 02:15
@Fred-sun Fred-sun added medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Sep 2, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 9b23370 into ansible-collections:dev Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbr23 @xuzhang3 @Fred-sun