Update identity support in sqlserver #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
Jul 10, 2024
|
@p3ck small changed request! |
Fred-sun
added
question
All set. I meant to remove the debug task before submitting it. Thanks! |
nirarg
reviewed
Jul 11, 2024
nirarg
previously approved these changes
Jul 14, 2024
Update identity to support UserAssigned and SystemAssigned,UserAssigned.
Co-authored-by: Fred-sun <[email protected]>
Thanks! I committed your suggestion |
Fred-sun
added
ready_for_review
|
Ping - Can you look at this again? Thanks |
Fred-sun
approved these changes
Aug 27, 2024
xuzhang3
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update identity to support UserAssigned and
SystemAssigned,UserAssigned.
ISSUE TYPE
COMPONENT NAME
plugins/modules/azure_rm_sqlserver.py
plugins/modules/azure_rm_sqlserver_info.py
tests/integration/targets/azure_rm_sqlserver/tasks/main.yml
ADDITIONAL INFORMATION
This expands the managed identity support from just SystemAssigned to include UserAssigned as well.