Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_batchaccount_info, azure_rm_batchaccountAdd Managed Identity support to BatchAccount module #1611

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

nirarg
Copy link
Collaborator

@nirarg nirarg commented Jun 27, 2024

SUMMARY

Add Managed Identity support to BatchAccount module

Changed module: azure_rm_batchaccount

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_batchaccount & azure_rm_batchaccount_info

@nirarg nirarg requested a review from p3ck June 27, 2024 08:16
Copy link
Collaborator

@p3ck p3ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of small changes.

plugins/module_utils/azure_rm_common_ext.py Show resolved Hide resolved
plugins/module_utils/azure_rm_common_ext.py Outdated Show resolved Hide resolved
plugins/module_utils/azure_rm_common_ext.py Outdated Show resolved Hide resolved
plugins/module_utils/azure_rm_common_ext.py Outdated Show resolved Hide resolved
plugins/module_utils/azure_rm_common_ext.py Show resolved Hide resolved
plugins/module_utils/azure_rm_common_ext.py Outdated Show resolved Hide resolved
Changed module: azure_rm_batchaccount
@p3ck p3ck added the ready_for_review The PR has been modified and can be reviewed and merged label Jul 1, 2024
@xuzhang3 xuzhang3 merged commit bee4121 into ansible-collections:dev Jul 2, 2024
@xuzhang3 xuzhang3 changed the title Add Managed Identity support to BatchAccount module azure_rm_batchaccount_info, azure_rm_batchaccountAdd Managed Identity support to BatchAccount module Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants