This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(core): fix #978, should be able to clear onhandler added before zone.js #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
force-pushed
the
onevent
branch
2 times, most recently
from
ea7f61b
to
dfa1bca
Compare
mhevery
approved these changes
Dec 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #978.
The issue can be described as
zone.js, add handler to onprop, such aselem.onload=function() {};.zone.js.elem.onload = null.elem.onloadis not cleared.We need try to clear the
onpropwith the non-patched descriptor.