This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
test(node): add task to run a subset of tests on node #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm run test-node` or `gulp test/node` will now run tests on node.js. These are also run on TravisCI. Clean up gulp build.
| import './test-env-setup'; | ||
|
|
||
| // List all tests here: | ||
| import './common/microtasks.spec'; |
There was a problem hiding this comment.
can we share this list with we the browser somehow? That way a test file added to the common would be added to both together?
|
LGTM. Could you pull common test into a common file? |
|
Done - merged as 89530fe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test-nodeorgulp test/nodewill now run testson node.js. These are also run on TravisCI. Clean up gulp
build.