Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName #1113

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

JiaLiPassion
Copy link
Collaborator

fix #1110.

In nodejs, EventEmitter should support Symbol as eventName.

const symbolA = Symbol('A');
emitter.addListener(symbolA, listener);
emitter.removeListener(symbolA, listener);

@JiaLiPassion JiaLiPassion changed the title fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName WIP(event): fix #1110, nodejs EventEmitter should support Symbol eventName Jul 17, 2018
@JiaLiPassion JiaLiPassion force-pushed the issue-1110 branch 2 times, most recently from 6f017d5 to 3fe873a Compare July 18, 2018 01:31
@JiaLiPassion JiaLiPassion changed the title WIP(event): fix #1110, nodejs EventEmitter should support Symbol eventName fix(event): fix #1110, nodejs EventEmitter should support Symbol eventName Jul 18, 2018
@jreidgreer
Copy link

@JiaLiPassion do you happen to know when this will get merged? Thanks!

@jreidgreer
Copy link

@JiaLiPassion do you have an update on when this might be merged in?

@JiaLiPassion
Copy link
Collaborator Author

@jreidgreer, I am not sure, If you want to test, I can create a temp release branch for you.

@Mathyn
Copy link

Mathyn commented Nov 6, 2018

Any updates on this? When can we expect this to be released?

@mhevery mhevery merged commit 96420d6 into angular:master Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

makeAddListener breaks when the Event Name is a Symbol
5 participants