Zone.js 0.8.17 and Angular-cli / rangeerror maximum call stack size exceeded #886

mhadaily · 2017-08-25T08:24:10Z

I thought that might be helpful If I open an issue in "zone.js" repo instead of "angular-cli".

Please refer to this comment angular/angular-cli#7502 (comment),

laurentgoudet · 2017-08-25T09:09:04Z

Same issue here, the v0.8.17 update broke our site, although there seems to be other things at play here since in our case disabling NewRelic Browser collection agent, which also patches XMLHttpRequest, "fixes" the issue. Either of them works fine without the other.

nename0 · 2017-08-25T09:18:03Z

Same here. I'm using pouchdb and since 0.8.17 when pouchdb makes network requests I get errors like this:

ERROR RangeError: Maximum call stack size exceeded
    at XMLHttpRequestUpload.wrapFn [as __zone_symbol__ON_PROPERTYprogress] (zone.js:1069)
    at XMLHttpRequestUpload.wrapFn [as __zone_symbol__ON_PROPERTYprogress] (zone.js:1075)
    at XMLHttpRequestUpload.wrapFn [as __zone_symbol__ON_PROPERTYprogress] (zone.js:1075)

From a bit of debugging it seems like in the new code at https://github.com/angular/zone.js/blob/master/lib/common/utils.ts#L98 listener gets the wrapFn funtion itself, which causes the infinite loop.

@JiaLiPassion you made this change. Any advice?

JiaLiPassion · 2017-08-25T09:26:19Z

please provide a reproduce repo, thanks, I will check it asap.

laurentgoudet · 2017-08-25T10:17:16Z

Reproduction plunkr here. Sorry NewRelic's code is minified as I couldn't find a way to reproduce it without it.

swftvsn · 2017-08-25T14:55:56Z

Same here, wasted a full day trying to trace this one. We're not using newrelic.

client.js:1587 Angular is running in the development mode. Call enableProdMode() to enable the production mode.
zone.js:196 Uncaught RangeError: Maximum call stack size exceeded
    at XMLHttpRequest.wrapFn (polyfills.bundle.js:1)
    at XMLHttpRequest.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (client.js:1655)
    at XMLHttpRequest.wrapFn (zone.js:1075)
    at XMLHttpRequest.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (client.js:1655)
    at XMLHttpRequest.wrapFn (zone.js:1075)
    at XMLHttpRequest.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (client.js:1655)
    at XMLHttpRequest.wrapFn (zone.js:1075)
    at XMLHttpRequest.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (client.js:1655)
    at XMLHttpRequest.wrapFn (zone.js:1075)
    at XMLHttpRequest.onreadystatechange [as __zone_symbol__ON_PROPERTYreadystatechange] (client.js:1655)
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.runTask @ zone.js:196
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneTask.invokeTask @ zone.js:499
invokeTask @ zone.js:1427
globalZoneAwareCallback @ zone.js:1445
XMLHttpRequest.send (async)
(anonymous) @ VM230:1
scheduleTask @ zone.js:2744
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.scheduleTask @ zone.js:411
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.scheduleTask @ zone.js:236
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.scheduleMacroTask @ zone.js:259
(anonymous) @ zone.js:2769
proto.(anonymous function) @ zone.js:1274
XMLHttpRequest.send @ client.js:1661
webpackJsonp.../../../../sockjs-client/lib/transport/browser/abstract-xhr.js.AbstractXHRObject._start @ abstract-xhr.js:132
(anonymous) @ abstract-xhr.js:21
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask @ zone.js:425
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.runTask @ zone.js:192
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneTask.invokeTask @ zone.js:499
ZoneTask.invoke @ zone.js:488
timer @ zone.js:1896
setTimeout (async)
scheduleTask @ zone.js:1906
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.scheduleTask @ zone.js:411
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.scheduleTask @ zone.js:236
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.scheduleMacroTask @ zone.js:259
(anonymous) @ zone.js:1932
proto.(anonymous function) @ zone.js:1274
AbstractXHRObject @ abstract-xhr.js:20
XHRLocalObject @ xhr-local.js:8
InfoAjax @ info-ajax.js:19
webpackJsonp.../../../../sockjs-client/lib/info-receiver.js.InfoReceiver._getReceiver @ info-receiver.js:36
webpackJsonp.../../../../sockjs-client/lib/info-receiver.js.InfoReceiver.doXhr @ info-receiver.js:56
(anonymous) @ info-receiver.js:25
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask @ zone.js:425
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.runTask @ zone.js:192
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneTask.invokeTask @ zone.js:499
ZoneTask.invoke @ zone.js:488
timer @ zone.js:1896
setTimeout (async)
scheduleTask @ zone.js:1906
webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.scheduleTask @ zone.js:411
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.scheduleTask @ zone.js:236
webpackJsonp.../../../../zone.js/dist/zone.js.Zone.scheduleMacroTask @ zone.js:259
(anonymous) @ zone.js:1932
proto.(anonymous function) @ zone.js:1274
InfoReceiver @ info-receiver.js:24
SockJS @ main.js:121
socket @ socket.js:7
(anonymous) @ client?ffdb:165
../../../../webpack-dev-server/client/index.js?http:/localhost:4200 @ client?ffdb:188
__webpack_require__ @ bootstrap 358e953892e2590113ae:54
0 @ main.bundle.js:5623
__webpack_require__ @ bootstrap 358e953892e2590113ae:54
webpackJsonpCallback @ bootstrap 358e953892e2590113ae:25
(anonymous) @ main.bundle.js:1
zone.js:196 Uncaught RangeError: Maximum call stack size exceeded
... the error keeps popping up ....

JiaLiPassion · 2017-08-25T18:00:09Z

Thank you everyone, sorry for the breaking error, I have made a PR to fix this one.
please try the attached zone.js.zip to verify whether the issue is resolved or not.
zone.js.zip

swftvsn · 2017-08-26T13:18:21Z

Hi,

I just tested and the problem is gone! Thank you for the quick turn around!

JiaLiPassion · 2017-08-26T19:24:57Z

@swftvsn , thank you for confirmation.

nename0 · 2017-08-26T22:57:35Z

Yep, the zip removes the problem for me too

picosam · 2017-08-28T00:57:54Z

I had posted a question about this here: https://stackoverflow.com/questions/45884672/uncaught-rangeerror-maximum-call-stack-size-exceeded-only-on-production

JiaLiPassion · 2017-08-28T02:28:23Z

@nename0 , thanks for confirm.
@picosam, please try the zip posted above to check whether the issue is resolved or not.

adrienverge · 2017-08-28T06:38:08Z

@JiaLiPassion, I confirm the zip fixes the problem for me too.

picosam · 2017-08-28T07:59:13Z

I'm really sorry, I'm unable to use npm to install the zip above. Would you like me to manually patch the files in node_modules with the ones in the zip and try?

JiaLiPassion · 2017-08-28T08:33:14Z

@picosam , yes, please download the zip, unzip and copy it to your node_modules/zone.js/dist folder to override the installed one.

@adrienverge , thank you for confirm.

laurentgoudet · 2017-08-28T13:14:51Z

I can confirm the patch seems to work as well.

picosam · 2017-08-28T13:35:18Z

Me too.

vincent-cm · 2017-09-04T16:09:55Z

Me too not using angularCli but webpack only. When navigation programmatically,
The following line is captured in the last line fo error:

at timer (http://0.0.0.0:8080/polyfills.bundle.js:18585:29)

JiaLiPassion · 2017-09-05T02:35:17Z

@laurentgoudet , @picosam , thanks for confirm.
@vincent-cm , please wait for next release of zone.js.

Ismaestro · 2017-09-07T13:34:25Z

@JiaLiPassion shit happens, we all know xD

JiaLiPassion · 2017-09-07T14:05:08Z

@Ismaestro , the new version not released, so please wait for a while. sorry for inconvenience

lakinmohapatra · 2017-09-08T11:29:51Z

When new version will be released ? We are eagerly waiting for this.

toverux · 2017-09-08T14:47:19Z

@lakinmohapatra You can downgrade to 0.8.16 while waiting for the fix.

mlc-mlapis · 2017-09-20T08:22:02Z

@JiaLiPassion ... I can confirm that zone.js.zip solved also the same problem when using raven-js.

dotlouis · 2017-09-28T08:39:21Z

New 0.8.18 version solved my issue

lakinmohapatra · 2017-09-28T08:40:07Z

Thnx

…

On Sep 28, 2017 2:09 PM, "louis" ***@***.***> wrote: New 0.8.18 solved the issue — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#886 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK7T3SCdGjW0xjubV5LiUaLp10bwlC0wks5sm1s9gaJpZM4PCXOT> .

lvncnt · 2017-09-29T03:04:41Z

tested, use zone.js version 0.8.18 solved the issue

mhadaily mentioned this issue Aug 25, 2017

Cannot read property '__zone_symbol__ON_PROPERTYreadystatechange' of null angular/angular-cli#7502

Closed

JiaLiPassion mentioned this issue Aug 25, 2017

fix(patch): fix #886, #885, patchOnProperties getter should return original listener. #887

Merged

mhevery closed this as completed in #887 Sep 6, 2017

MaxTschuchnig mentioned this issue Sep 12, 2017

Replication mechanism in 3.3.1 compared to 2.2.3 + "Maximum call stack size exceeded error" in 2.2.3 pouchdb/pouchdb#3635

Closed

rokob mentioned this issue Sep 20, 2017

Anguar application error reports result in recursive "Maximum call stack size exceeded" rollbar/rollbar.js#425

Closed

Jimmysh mentioned this issue Sep 29, 2017

zone.js 0.8.17 XMLHttpRequest Bug ionic-team/ionic-framework#13014

Closed

jesusbotella mentioned this issue Sep 29, 2017

Ionic 3.7.0 - Client init generates never ending error loop getsentry/sentry-javascript#1062

Closed

duydao mentioned this issue Sep 30, 2017

Maximum call stack exceeded when running Dexie with zone.js 0.8.18 dexie/Dexie.js#589

Closed

vmihailenco mentioned this issue Oct 31, 2017

Angular 4 & TypeScript issue. airbrake/airbrake-js#367

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zone.js 0.8.17 and Angular-cli / rangeerror maximum call stack size exceeded #886

Zone.js 0.8.17 and Angular-cli / rangeerror maximum call stack size exceeded #886

mhadaily commented Aug 25, 2017

laurentgoudet commented Aug 25, 2017

nename0 commented Aug 25, 2017 •

edited

Loading

JiaLiPassion commented Aug 25, 2017

laurentgoudet commented Aug 25, 2017

swftvsn commented Aug 25, 2017

JiaLiPassion commented Aug 25, 2017 •

edited

Loading

swftvsn commented Aug 26, 2017

JiaLiPassion commented Aug 26, 2017

nename0 commented Aug 26, 2017

picosam commented Aug 28, 2017

JiaLiPassion commented Aug 28, 2017

adrienverge commented Aug 28, 2017

picosam commented Aug 28, 2017

JiaLiPassion commented Aug 28, 2017

laurentgoudet commented Aug 28, 2017

picosam commented Aug 28, 2017

vincent-cm commented Sep 4, 2017

JiaLiPassion commented Sep 5, 2017

Ismaestro commented Sep 7, 2017

JiaLiPassion commented Sep 7, 2017

lakinmohapatra commented Sep 8, 2017

toverux commented Sep 8, 2017

mlc-mlapis commented Sep 20, 2017

dotlouis commented Sep 28, 2017 •

edited

Loading

lakinmohapatra commented Sep 28, 2017 via email

lvncnt commented Sep 29, 2017 •

edited

Loading

Zone.js 0.8.17 and Angular-cli / rangeerror maximum call stack size exceeded #886

Zone.js 0.8.17 and Angular-cli / rangeerror maximum call stack size exceeded #886

Comments

mhadaily commented Aug 25, 2017

laurentgoudet commented Aug 25, 2017

nename0 commented Aug 25, 2017 • edited Loading

JiaLiPassion commented Aug 25, 2017

laurentgoudet commented Aug 25, 2017

swftvsn commented Aug 25, 2017

JiaLiPassion commented Aug 25, 2017 • edited Loading

swftvsn commented Aug 26, 2017

JiaLiPassion commented Aug 26, 2017

nename0 commented Aug 26, 2017

picosam commented Aug 28, 2017

JiaLiPassion commented Aug 28, 2017

adrienverge commented Aug 28, 2017

picosam commented Aug 28, 2017

JiaLiPassion commented Aug 28, 2017

laurentgoudet commented Aug 28, 2017

picosam commented Aug 28, 2017

vincent-cm commented Sep 4, 2017

JiaLiPassion commented Sep 5, 2017

Ismaestro commented Sep 7, 2017

JiaLiPassion commented Sep 7, 2017

lakinmohapatra commented Sep 8, 2017

toverux commented Sep 8, 2017

mlc-mlapis commented Sep 20, 2017

dotlouis commented Sep 28, 2017 • edited Loading

lakinmohapatra commented Sep 28, 2017 via email

lvncnt commented Sep 29, 2017 • edited Loading

nename0 commented Aug 25, 2017 •

edited

Loading

JiaLiPassion commented Aug 25, 2017 •

edited

Loading

dotlouis commented Sep 28, 2017 •

edited

Loading

lvncnt commented Sep 29, 2017 •

edited

Loading