Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

HTMLCanvasElement.toBlob callback is run outside current zone #696

Closed
nicolashenry opened this issue Mar 23, 2017 · 4 comments · Fixed by #788
Closed

HTMLCanvasElement.toBlob callback is run outside current zone #696

nicolashenry opened this issue Mar 23, 2017 · 4 comments · Fixed by #788

Comments

@nicolashenry
Copy link

HTMLCanvasElement.toBlob callback is run outside current zone.
It seems that this method is not wrapped by zone.js.
@JiaLiPassion
Copy link
Collaborator

thank you for posting the issue, I will wrap it.

JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue May 20, 2017
@JiaLiPassion
feat(patch): fix angular#696, patch HTMLCanvasElement.toBlob as Macro…
6f3e9d4 
…Task
JiaLiPassion added a commit to JiaLiPassion/zone.js that referenced this issue May 20, 2017
@JiaLiPassion
feat(patch): fix angular#696, patch HTMLCanvasElement.toBlob as Macro…
e092b6c 
…Task
@JiaLiPassion JiaLiPassion mentioned this issue May 20, 2017
Merged
mhevery pushed a commit that referenced this issue Jun 2, 2017
@JiaLiPassion @mhevery
feat(patch): fix #696, patch HTMLCanvasElement.toBlob as MacroTask (#788
7ca3995 
)
@clark0x
Copy link

clark0x commented Dec 1, 2017

It seems that this patch cause Safari throws an error

SecurityError (DOM Exception 18): The operation is insecure.
toBlob

@JiaLiPassion
Copy link
Collaborator

@clarkorz, could you provide the safari version and os version? thank you.

@clark0x
Copy link

clark0x commented Dec 1, 2017

Safari 11.0.1 (12604.3.5.1.1)
Mac 10.13.1 (17B1003)

We are trying to use image-compressor in our angular5 project. related issue: fengyuanchen/compressorjs#17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(patch): fix #696, patch HTMLCanvasElement.toBlob as MacroTask JiaLiPassion/zone.js
3 participants
@nicolashenry @JiaLiPassion @clark0x