Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

XMLHttpRequest use readyState constants on target instead global interface #394

Closed
hmdhk opened this issue Aug 12, 2016 · 0 comments · Fixed by #395
Closed

XMLHttpRequest use readyState constants on target instead global interface #394

hmdhk opened this issue Aug 12, 2016 · 0 comments · Fixed by #395

Comments

@hmdhk
Copy link
Contributor

hmdhk commented Aug 12, 2016 •
edited
Loading

Some libraries (e.g. offline.js) patch XMLHttpRequest, but they don't expose readyState constants (for example XMLHttpRequest.DONE is undefined which causes the macrotask to never get invoked).
Given that those constants are part of the standard only for the actual instance, we should use those constants on the target instead of global XMLHttpRequest
hmdhk added a commit to hmdhk/zone.js that referenced this issue Aug 12, 2016
@hmdhk
fix(browser): use XMLHttpRequest.DONE constant on target instead of t…
95e39bc 
…he global interface

fixes angular#394
@hmdhk hmdhk mentioned this issue Aug 12, 2016
Merged
hmdhk added a commit to hmdhk/zone.js that referenced this issue Aug 20, 2016
@hmdhk
fix(browser): use XMLHttpRequest.DONE constant on target instead of t…
177ad3d 
…he global interface

fixes angular#394
mhevery pushed a commit that referenced this issue Aug 22, 2016
@jahtalab @mhevery
fix(browser): use XMLHttpRequest.DONE constant on target instead of t…
3b4c20b 
…he global interface (#395)

fixes #394
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(browser): use XMLHttpRequest.DONE constant on target instead of t... hmdhk/zone.js
1 participant
@hmdhk