Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement extend-theme functions for each component & overhaul override mixins to match behavior #29275

Closed
wants to merge 5 commits into from
Closed

Implement extend-theme functions for each component & overhaul override mixins to match behavior #29275

wants to merge 5 commits into from

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Jun 17, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 17, 2024
andrewseguin
andrewseguin approved these changes Jun 18, 2024
View reviewed changes
src/material/core/tokens/_token-utils.scss Outdated Show resolved Hide resolved
src/material/core/tokens/_token-utils.scss Outdated Show resolved Hide resolved
@mmalerba mmalerba changed the title feat(material/theming): extend-theme sass function feat(material/theming): Add <component>-extend-theme sass functions Jun 18, 2024
@mmalerba mmalerba force-pushed the extend-theme branch 3 times, most recently from b6e4fba to 7ce26a8 Compare June 28, 2024 00:16
@mmalerba mmalerba added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Jun 28, 2024
@mmalerba mmalerba changed the title feat(material/theming): Add <component>-extend-theme sass functions Implement extend-theme functions for each component & overhaul override mixins to match behavior Jun 28, 2024
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Jun 28, 2024
@mmalerba mmalerba force-pushed the extend-theme branch 5 times, most recently from d450944 to 76e337a Compare June 30, 2024 05:12
@mmalerba mmalerba added this to the 19.0.0 milestone Jun 30, 2024
@mmalerba mmalerba marked this pull request as ready for review June 30, 2024 05:21
@mmalerba mmalerba requested a review from a team as a code owner June 30, 2024 05:21
@mmalerba mmalerba requested review from crisbeto and amysorto and removed request for a team June 30, 2024 05:21
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jul 2, 2024
@mmalerba mmalerba force-pushed the extend-theme branch 2 times, most recently from 361cb9b to cc82e87 Compare July 2, 2024 21:17
@mmalerba mmalerba force-pushed the extend-theme branch 7 times, most recently from ecba587 to 93fdbe3 Compare July 10, 2024 15:33
@crisbeto crisbeto mentioned this pull request Jul 11, 2024
Open
@mmalerba mmalerba force-pushed the extend-theme branch 3 times, most recently from 8120340 to cea28c3 Compare July 16, 2024 22:53
wagnermaciel and others added 5 commits August 6, 2024 17:08
@wagnermaciel @mmalerba
feat(material/theming): Add <component>-extend-theme sass functions
2f4ea52 
Initial commit, adds shared logic for appling overrides without
validation of the given tokens.
@mmalerba
fix(material/theming): Add validation to shared extend-theme logic
b23939b 
Adds validation to the shared extend-theme logic along with tests to
verify its behavior.
@mmalerba
feat(material/theming): Add <component>-extend-theme functions
64cd179 
Adds the individual extend-theme functions for each component that
delegate to the shared logic.
@mmalerba
fix(material/theming): add validation for <component>-extend-theme fu…
8ed70c0 
…nctions

Adds a test to validate that the individual extend-theme functions do
not have issues with unhandled overlapping short token names, and fixes
issues that were uncovered.
@mmalerba
fix(material/theming): disambiguate token names in extend-theme funct…
da96c03 
…ions

Avoids token name collisions between namespaces by assigning string
prefixes to token in namespaces that would otherwise have a collision
@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 7, 2024

Per the team meeting discussion, we've decided to shelve this for now while we take a more holistic look at our theming system overall

@mmalerba mmalerba closed this Aug 7, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@amysorto amysorto Awaiting requested review from amysorto amysorto is a code owner automatically assigned from angular/components-googlers

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: preserve commits When the PR is merged, a rebase and merge should be performed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @andrewseguin @wagnermaciel