Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to Typescript 3.6 #17428

Merged
merged 2 commits into from
Oct 23, 2019
Merged

build: update to Typescript 3.6 #17428

merged 2 commits into from
Oct 23, 2019

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 17, 2019 •
edited
Loading

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2019
@jelbourn jelbourn force-pushed the typescript-3.6 branch 2 times, most recently from f7456e0 to bcd27e3 Compare October 22, 2019 02:42
@jelbourn jelbourn added target: major This PR is targeted for the next major release P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Oct 22, 2019
@jelbourn jelbourn marked this pull request as ready for review October 22, 2019 18:19
@mmalerba mmalerba changed the title Typescript 3.6 build: update to Typescript 3.6 Oct 22, 2019
crisbeto
crisbeto approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmalerba
mmalerba reviewed Oct 22, 2019
View reviewed changes
src/material/menu/menu.spec.ts
@@ -1071,8 +1071,8 @@ describe('MatMenu', () => {
// In "before" position, the right sides of the overlay and the origin are aligned.
// To find the overlay left, subtract the menu width from the origin's right side.
const expectedLeft = triggerRect.right - overlayRect.width;
expect(Math.floor(overlayRect.left))
.toBe(Math.floor(expectedLeft),
expect(Math.abs(Math.floor(overlayRect.left) - Math.floor(expectedLeft)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to TS update or just fixing flaky tests while you're here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this test changes by 1px in Firefox consistently with TS 3.6.

src/cdk/clipboard/pending-copy.ts Show resolved Hide resolved
src/cdk/overlay/overlay-config.ts Outdated Show resolved Hide resolved
devversion
devversion approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 22, 2019
@ngbot
Copy link

ngbot bot commented Oct 22, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: ivy_test" is failing
    pending status "ci/circleci: api_golden_checks" is pending
    pending status "ci/circleci: bazel_build" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba added this to the 9.0.0 milestone Oct 22, 2019
Splaktar
Splaktar approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1ad9ef0 into angular:master Oct 23, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Splaktar Splaktar Splaktar approved these changes

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jelbourn @Splaktar @crisbeto @devversion @mmalerba @googlebot