build: add linting for classList usage #17388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
classlist-signature-linting
branch
2 times, most recently
from
721ad03
to
d71b933
Compare
Once in a while we hit an issue because we use some of the `classList` methods in a way that isn't supported in all browsers (e.g. passing multiple parameters to `add` in angular#17378). These changes add a simple lint rule to catch these cases earlier.
crisbeto
force-pushed
the
classlist-signature-linting
branch
from
d71b933
to
596fa24
Compare
crisbeto
commented
Oct 13, 2019
| // For each of the variant selectors that is present in the button's host | ||
| // attributes, add the correct corresponding MDC classes. | ||
| for (const pair of HOST_SELECTOR_MDC_CLASS_PAIR) { | ||
| if (this._hasHostAttributes(pair.selector)) { | ||
| (elementRef.nativeElement as HTMLElement).classList.add(...pair.mdcClasses); |
There was a problem hiding this comment.
Looks like we had one of these already that we hadn't noticed.
devversion
approved these changes
Oct 14, 2019
mmalerba
approved these changes
Oct 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once in a while we hit an issue because we use some of the
classListmethods in a way that isn't supported in all browsers (e.g. passing multiple parameters toaddin #17378). These changes add a simple lint rule to catch these cases earlier.