-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): not closed correctly if opened by different trigger while visible #15373
Open
crisbeto
wants to merge
1
commit into
angular:main
Choose a base branch
from
crisbeto:15354/menu-multiple-trigger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Mar 3, 2019
When this PR can be merged ? |
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
May 2, 2019 06:26
369ca01
to
4bc8f63
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
2 times, most recently
from
May 24, 2019 05:36
0c51b2c
to
d3e0f36
Compare
andrewseguin
added
the
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
label
May 30, 2019
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
July 18, 2019 21:03
d3e0f36
to
949bd88
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
October 1, 2019 19:31
949bd88
to
078951d
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
February 1, 2020 16:20
078951d
to
f581ea3
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
April 17, 2020 18:50
f581ea3
to
06943e1
Compare
…visible Fixes the `MatMenu` overlay not being detached if the menu is opened by a different trigger while the panel is still open. Fixes angular#15354.
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
July 25, 2020 15:45
06943e1
to
a431705
Compare
@crisbeto It looks like this PR is outdated, please rebase the PR. |
andrewseguin
removed
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Dec 29, 2021
andrewseguin
removed
the
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
label
Mar 28, 2022
josephperrott
added
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
and removed
needs rebase
labels
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
MatMenu
overlay not being detached if the menu is opened by a different trigger while the panel is still open.Fixes #15354.