Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master README.md #266

Merged
merged 5 commits into from
Jan 24, 2017
Merged

Update master README.md #266

merged 5 commits into from
Jan 24, 2017

Conversation

sharifsalah
Copy link
Contributor

Updates the master README as follows:

Fixes typos
Proof reading, including grammar
New titles
More consistent terminology (project vs sample)
Adjust formatting
Updates contributors
Various style changes

@florina-muntenescu
Copy link
Contributor

LGTM

Amends name of TODO-DataBinding sample
Updates all references to repository branches to use lowercase for consistency. Various other minor formatting improvements.
maintainability. However, bear in mind that there are many ways to build apps
with these architectures and tools, depending on your priorities, so these
shouldn't be considered canonical examples. The UI is deliberately kept simple.
You can use the samples in this project as a learning reference, or as a starting point for creating your own apps. The focus of this project is on demonstrating how to structure your code, design your architecture, and the eventual impact of adopting these patterns on testing and maintaining your app. You can use the techniques demonstrated here in many different ways to build apps. Your own particular priorities will impact how you implement the concepts in these projects, so you should not consider these samples to be canonical examples. To ensure the focus in kept on the aims described above, the app uses a simple UI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

focus is kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'is kept' is passive, so I suggest keeping it more focused as it is.

@JoseAlcerreca
Copy link
Contributor

LGTM

Replaces hyphens with non-breaking hyphens.
Copy link
Contributor

@JoseAlcerreca JoseAlcerreca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sharif!

@JoseAlcerreca JoseAlcerreca merged commit 0bc6105 into android:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants