Fix/window crashes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbc1 - casting to u16 when the program length in mbc1 carts can be greater than u16. read or write to the ram when there is not ram read or writes are ignored Add support for ignoring and not crashing gb_ppu - when calculating the next ppu state change did not count the vblank state when the counter get greater than 114 m_cycles. Now Im using modolu of 114 on the cycles to handle this sprite_fetcher - a bug where the flipx calculation was off by the amount of pixels needs to skip causing panic. It seems to be unecessary so I reomved it.
alloncm
force-pushed
the
fix/window_crashes
branch
from
77a5fe8
to
cbdd53c
Compare
Fixed 2 bugs: sdl_pull_audio_device - aside from naming, fixed a bug where memseting outside of bounds cause heap corruption fixed_size_queue - aside from naming, fixed a bug where index and index_mut caused accessing memory outside of bounds. Funny thing is that when allocating with vec![] and with with_capacity, the corruption did not happen, my guess is that since vec![] macro simply allocates a bigger buffer and the out of bounds writes did not corrupt anything.
|
https://mgba-emu.github.io/gbdoc/ a good docs about the ppu |
alloncm
force-pushed
the
fix/window_crashes
branch
from
ebf5559
to
60603d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.