Feature fifo ppu #51

alloncm · 2021-06-19T10:53:07Z

This new implementation should be more accurate and faster than the current one.

Closes #50
Closes #52

alloncm · 2021-07-23T21:30:47Z

Add this video to the resources - https://www.youtube.com/watch?v=HyzD8pNlpwI

and progressed with the fifo implementation

The bootrom npw displays the logo!

Not working as intended

Rendered the first tile twice in the bg

to include the ultimate gb talk as one of the resources

Ordering the sprites after fetching them from oam ram

Both fifos cant operate at the same time. the sprite fifo stops the bg fifo and the pixels to the lcd pusher.

The fifo is 8 pxiels length. If it contains pixels from previous sprite the new sprite first number of pixels in the fifo are discarded and not pushed to the fifo. This way sprite whos ovelapping wont override each other and the sprite with the lowest x value (higher priority) will be drawn.

The bug was a case when the x position is more advanced than the start of the obj x pos. the pixels would still be pushed and we will end up with more than 8 pixels in the fifo. Solve it by checking the x pos too.

I think I know how to solve the problem with the x axis scroll animation It has something to do with SCX mod 8 pixels wich are discarded at the beginning of the stage 3 (push).

Allow the smooth moving animation on X axis

The bug would ocour only for objects drawn with odd scx register. Since the state machine of the sprite fetcher worked in steps of 2 t_cycles it would miss some lines. Moved the state machine to work for every t_cycle and not for the even ones.

# Conflicts: # lib_gb/src/machine/gameboy.rs

lib_gb/src/machine/gameboy.rs

lib_gb/src/ppu/fifo/sprite_fetcher.rs

gb/src/sdl_gfx_device.rs

lib_gb/src/machine/gameboy.rs

lib_gb/src/ppu/fifo/bg_fetcher.rs

lib_gb/src/ppu/fifo/fifo_ppu.rs

lib_gb/src/ppu/fifo/sprite_fetcher.rs

alloncm · 2021-09-03T20:21:28Z

Remove all the regular PPU files and change the fifo ppu name to gb_ppu

This commit is a result of a SCR (self code review).

lib_gb/src/ppu/fifo/bg_fetcher.rs

alloncm · 2021-09-04T22:31:24Z

Squash the WIP commit (42b2fdb) with the next one (7bee195)

lib_gb/src/ppu/fifo/bg_fetcher.rs

lib_gb/src/ppu/fifo/fetcher_state_machine.rs

lib_gb/src/ppu/fifo/fetching_state.rs

lib_gb/src/mmu/io_components.rs

lib_gb/src/ppu/fifo/bg_fetcher.rs

lib_gb/src/ppu/fifo/fifo_ppu.rs

Now using a better state machine mechanism.

SCR - Arrange code and extract some to functions, fix typos and made some fields private

Change BGFetcher to BackgroundFetcher Move the to color code into the color mod

Made this more safe and less error prone

Replaced the scanline based ppu with the fifo ppu and adpted the rest of the project to it

Added a lot of constants for the code to make it clearer

Add some tests (not fully coverage) the code still dont works

In rust ! operator will bitwise not integers, I forgot to add a proper pranthesis and this broke the ppu

Implement the window rendering correctly: - handle the LY==WY case - increment the internal window counter correctly (only when LY is greater than WY) - Some more fixes (reseting vars on vblank etc)

- New const - Remove redundant field - arrange code

alloncm added 7 commits June 5, 2021 23:59

Starting to implement a fifo ppu

cdbee8e

WIP in the middle of the fifo ppy

3c2c2bb

The fifo supposed to support the bg layer

427df0e

Wrap the fifo code in order to start and test it

35b9946

WIP adding the registers to the new ppu

9587841

Remove uncessary function

683e2df

Add support for the registers

67f49ba

alloncm added 22 commits July 24, 2021 00:46

Add gfx device and sdl gfx device

601b75e

and progressed with the fifo implementation

Fix the fetiching tile number stage in the new ppu

3ce9e29

The bootrom npw displays the logo!

Fix the timing issue with the fifo ppu

3a299f7

FIx a vblank interrupt not fired

58dc36f

Hope I fixed the stat interrupt trigger

a43c095

More fixes for the interrupt

e4ba52e

Move the fifo stuff to its own folder

f350e62

Integrate the bg fetcher

9bfe553

Add the sprite fetcher

391b362

Integrate the sprite fetcher

58e64e2

Not working as intended

Still implementing the sprites

dd28221

Fix bugs u8 overflow and rendering

260414d

Rendered the first tile twice in the bg

First sprites on the screen!

9aff501

Fix the stat interrupt and support for hiding bg

db57edf

Adding propper support for the window

e361544

Adapt to linux and amde error message clearer

16daae8

Fix the window rendering

00e7457

Update the readme

ecd624d

to include the ultimate gb talk as one of the resources

Fix sprite fetcher

894339d

Ordering the sprites after fetching them from oam ram

Seperate the pixel x pos from the bg x pos

5f845a3

The bg stops render when a sprite has been found

c3d0a4f

Both fifos cant operate at the same time. the sprite fifo stops the bg fifo and the pixels to the lcd pusher.

alloncm added 3 commits August 20, 2021 18:28

Fix the fifo obj rendering

d959651

The bug was a case when the x position is more advanced than the start of the obj x pos. the pixels would still be pushed and we will end up with more than 8 pixels in the fifo. Solve it by checking the x pos too.

Arrange the bg fetcher code.

69a3e94

I think I know how to solve the problem with the x axis scroll animation It has something to do with SCX mod 8 pixels wich are discarded at the beginning of the stage 3 (push).

Fix the bg rendering

1926087

Allow the smooth moving animation on X axis

alloncm force-pushed the feature-fifo_ppu branch from eb03d73 to 1926087 Compare August 21, 2021 18:48

alloncm marked this pull request as ready for review September 3, 2021 17:19

alloncm added 2 commits September 3, 2021 20:24

Arrange the gameboy main code

f52c16c

Merge branch 'dev' into feature-fifo_ppu

dcd3e63

# Conflicts: # lib_gb/src/machine/gameboy.rs

alloncm commented Sep 3, 2021

View reviewed changes

Code indentation and redundant code removal

b71436e

This commit is a result of a SCR (self code review).

alloncm commented Sep 3, 2021

View reviewed changes

lib_gb/src/ppu/fifo/bg_fetcher.rs Outdated Show resolved Hide resolved

alloncm commented Sep 5, 2021

View reviewed changes

lib_gb/src/ppu/fifo/bg_fetcher.rs Outdated Show resolved Hide resolved

lib_gb/src/ppu/fifo/fetcher_state_machine.rs Outdated Show resolved Hide resolved

lib_gb/src/ppu/fifo/fetching_state.rs Outdated Show resolved Hide resolved

alloncm commented Sep 6, 2021

View reviewed changes

lib_gb/src/mmu/io_components.rs Outdated Show resolved Hide resolved

lib_gb/src/ppu/fifo/bg_fetcher.rs Outdated Show resolved Hide resolved

lib_gb/src/ppu/fifo/fifo_ppu.rs Outdated Show resolved Hide resolved

lib_gb/src/ppu/fifo/fifo_ppu.rs Outdated Show resolved Hide resolved

Refactor the fetchers

15b1b6c

Now using a better state machine mechanism.

alloncm force-pushed the feature-fifo_ppu branch from 7bee195 to 15b1b6c Compare September 6, 2021 10:35

alloncm added 6 commits September 6, 2021 13:56

Arrange the fifo code

0b3b51d

SCR - Arrange code and extract some to functions, fix typos and made some fields private

Arrange and rename

fdc2624

Change BGFetcher to BackgroundFetcher Move the to color code into the color mod

Change FetchingStateData to a struct from union

a3513c1

Made this more safe and less error prone

Remove unused files and modules

6380c55

Replaced the scanline based ppu with the fifo ppu and adpted the rest of the project to it

Change magic numbers into consts and fix casting

73dbb19

Added a lot of constants for the code to make it clearer

Implemented the fifo DS + some tests

d2fe771

Add some tests (not fully coverage) the code still dont works

alloncm force-pushed the feature-fifo_ppu branch from ff498ca to d2fe771 Compare September 8, 2021 13:27

alloncm added 4 commits September 8, 2021 16:38

Clean the create array util

cc472ce

Fix this weird bug where the image is courupted

4fec856

In rust ! operator will bitwise not integers, I forgot to add a proper pranthesis and this broke the ppu

Fix the window rendering, passing the turtle tests

4142854

Implement the window rendering correctly: - handle the LY==WY case - increment the internal window counter correctly (only when LY is greater than WY) - Some more fixes (reseting vars on vblank etc)

SCR

b4347cd

- New const - Remove redundant field - arrange code

alloncm merged commit d9793c7 into dev Sep 9, 2021

alloncm deleted the feature-fifo_ppu branch September 9, 2021 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature fifo ppu #51

Feature fifo ppu #51

alloncm commented Jun 19, 2021 •

edited

Loading

alloncm commented Jul 23, 2021

alloncm commented Sep 3, 2021

alloncm commented Sep 4, 2021

Feature fifo ppu #51

Feature fifo ppu #51

Conversation

alloncm commented Jun 19, 2021 • edited Loading

alloncm commented Jul 23, 2021

alloncm commented Sep 3, 2021

alloncm commented Sep 4, 2021

alloncm commented Jun 19, 2021 •

edited

Loading