refactor: optimize text listener #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuanyan
reviewed
Mar 18, 2019
yuanyan
reviewed
Mar 18, 2019
| @@ -64,7 +65,9 @@ export default class TextElement extends HTMLElement { | |||
| } | |||
|
|
|||
| connectedCallback() { | |||
| this.childrenObserver = new FlattenedNodesObserver(this, this._observeChildren); | |||
| afterNextRender(this, () => { | |||
There was a problem hiding this comment.
afterNextRender 好像就是 requestFrameCallback
There was a problem hiding this comment.
嗯 原理上是一样的，但是实现不同.
afterNextRender 会共用同一个 frame 来执行同一个tick触发的callback
如果这里改成 requestAnimationFrame 的话, 实测1000节点70ms左右, 跟原先不优化的效果差不多, 比 setTimeout 也要多 20% 左右的时间(50-60ms).
查了下可能是下面这个原因
浏览器 requestAnimationFrame 的实现比较复杂，需要在 UI 线程注册 vSync 的回调，并且涉及多次进程/线程间的双向通讯
yuanyan
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重复渲染 1000 次 text 节点, 上屏时间减少 50%