-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support dimensional prop value without px #1467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanyan
reviewed
Nov 5, 2019
Driver-dom 此处判断有误: function isRpx(str) {
return typeof str === 'string' && str.slice(0, -3) === 'rpx';
} 此方法应为 slice(-3),同时不能识别 margin '10rpx 10rpx',未收敛至 style-unit 目前需进一步修改 fixed |
yuanyan
reviewed
Nov 6, 2019
yuanyan
reviewed
Nov 6, 2019
fyangstudio
changed the title
fix: support dimensional prop value without px
[WIP]fix: support dimensional prop value without px
Nov 7, 2019
wssgcg1213
reviewed
Nov 7, 2019
fyangstudio
changed the title
[WIP]fix: support dimensional prop value without px
fix: support dimensional prop value without px
Nov 11, 2019
wssgcg1213
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update driver-universal.
This PR make driver-universal consistent with driver-dom processing style in web app.
support dimensional prop value without px.
<div style={{width: 100}} />
to<div style="width: 100rpx" />
see: fix: support dimensional prop value without px #1456
'rpx' translate to 'vw' in web app.(driver-dom)
<div style={{width: '75rpx'}} />
to<div style="width: 10vw" />
when viewportWidth is 750Compare