Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error boundary bug and remove useless code #1414

Merged
merged 6 commits into from
Oct 6, 2019
Merged

fix: error boundary bug and remove useless code #1414

merged 6 commits into from
Oct 6, 2019

Conversation

yongningfu
Copy link
Collaborator

  1. 目前的error boundary在子节点单独渲染发生错误的时候，不会触发didCapture
  2. didMount和didUpdate里面setState, callback执行的时机不太对，导致获取的state有问题
  3. renderedElement的判断 和
    update中的stash callback 逻辑看起来没用处
  4. gzip: 6.27 -> 6.21

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@yuanyan yuanyan merged commit 3000ad6 into alibaba:master Oct 6, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanyan yuanyan yuanyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongningfu @CLAassistant @yuanyan