Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply some performance optimisation #1330

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Apply some performance optimisation #1330

merged 2 commits into from
Sep 4, 2019

Conversation

wssgcg1213
Copy link
Collaborator

  1. use textContent instead of innerHTML
  2. use isNull instead of xxx === null: from xxx===null to f(xxx), decrease 4 chars each call.

@wssgcg1213
Copy link
Collaborator Author

image
https://mrale.ph/blog/2015/01/11/whats-up-with-monomorphism.html

@yuanyan yuanyan merged commit a0b5be0 into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor-rax-core-performance branch September 4, 2019 09:25
@weekly-digest weekly-digest bot mentioned this pull request Sep 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanyan yuanyan yuanyan approved these changes

@chenjun1011 chenjun1011 Awaiting requested review from chenjun1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wssgcg1213 @yuanyan