Feat user config #1253
Merged
Feat user config #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Orange-C
commented
Aug 14, 2019
Orange-C
commented
- all user config handled together
- add devServer config
chenjun1011
requested changes
Aug 14, 2019
| const { setBabelAlias } = require('rax-compile-config'); | ||
| const UglifyJSPlugin = require('uglifyjs-webpack-plugin'); | ||
| const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin'); | ||
| const { getBabelConfig, setBabelAlias } = require('rax-compile-config'); |
There was a problem hiding this comment.
webpack 的 config 是不是也可以提出去？
There was a problem hiding this comment.
这份目前看只有app使用，如果未来其他plugin或者component那些都有了可以提
| @@ -108,8 +33,5 @@ module.exports = (context) => { | |||
| render: serverRender.renderToString, | |||
There was a problem hiding this comment.
为什么要从外面传一个 render 进去，而不是直接包掉这个逻辑
There was a problem hiding this comment.
考虑到未来ice会使用react作为core的场景
There was a problem hiding this comment.
不如直接传 renderToString 方法
There was a problem hiding this comment.
不如直接传 renderToString 方法
字段名改成renderToString？
There was a problem hiding this comment.
看了下已经内置了rax的createElement逻辑了，还是把这个逻辑内置了吧，我改一下
chenjun1011
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.