Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filename typo #1054

Merged
merged 1 commit into from
May 6, 2019
Merged

fix: filename typo #1054

merged 1 commit into from
May 6, 2019

Conversation

yuanyan
Copy link
Collaborator

@yuanyan yuanyan commented May 6, 2019

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@yuanyan yuanyan requested review from yacheng and wssgcg1213 May 6, 2019 03:23
wssgcg1213
wssgcg1213 approved these changes May 6, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@yuanyan yuanyan merged commit 15961fa into master May 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the yuanyan-patch-1 branch May 6, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@yacheng yacheng Awaiting requested review from yacheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanyan @wssgcg1213