refactor: replace lodash/isEqual with react-fast-compare #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoyunhe
force-pushed
the
drop-lodash-is-equal
branch
from
28bbae3
to
3596fd3
Compare
guoyunhe
force-pushed
the
drop-lodash-is-equal
branch
from
3596fd3
to
06dd454
Compare
liuyib
approved these changes
Feb 26, 2024
|
@li-jia-nan @hchlq @miracles1919 @crazylxr |
我也没用过这个 |
|
v4 再换吧，先 hold 一下 |
|
@liuyib antd-mobile 已经换了，目前没有发现问题 https://github.com/ant-design/ant-design-mobile/blob/master/package.json#L33 |
|
那就整 |
raotaohub
pushed a commit
to raotaohub/hooks
that referenced
this pull request
Mar 28, 2024
* refactor: replace lodash/isEqual with react-fast-compare * chore: update lock --------- Co-authored-by: 云泥 <[email protected]>
crazylxr
added a commit
that referenced
this pull request
Apr 11, 2024
* refactor: replace lodash/isEqual with react-fast-compare (#2458) * refactor: replace lodash/isEqual with react-fast-compare * chore: update lock --------- Co-authored-by: 云泥 <[email protected]> * refactor(useRafInterval): optimize useEffect cleanup fn (#2426) * fix(useAntdTable): 修复动态设置 ready 失效的 bug (#2489) * refactor(useLockFn): catch to finally (#2421) * refactor(useLockFn): catch to finally * refactor(useLockFn): keep the throw e * refactor(createEffectWithTarget): the first parameter is old-deps (#2431) * fix(useCountDown): targetDate resets leftTime (#2346) * chore: update version --------- Co-authored-by: Guo Yunhe <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: guaijie <[email protected]> Co-authored-by: joe-leong <[email protected]> Co-authored-by: 潇见 <[email protected]>
crazylxr
added a commit
that referenced
this pull request
Apr 22, 2024
* refactor: replace lodash/isEqual with react-fast-compare (#2458) * refactor: replace lodash/isEqual with react-fast-compare * chore: update lock --------- Co-authored-by: 云泥 <[email protected]> * refactor(useRafInterval): optimize useEffect cleanup fn (#2426) * fix(useAntdTable): 修复动态设置 ready 失效的 bug (#2489) * refactor(useLockFn): catch to finally (#2421) * refactor(useLockFn): catch to finally * refactor(useLockFn): keep the throw e * refactor(createEffectWithTarget): the first parameter is old-deps (#2431) * fix(useCountDown): targetDate resets leftTime (#2346) * chore: update version * fix(type): fixed up some types that are non-standard and errors on `useExteneral` hook (#2508) * fix(type): fixed up some types that are non-standard and errors on `useExternal` hook * style: format * refactor: simplify --------- Co-authored-by: liuyib <[email protected]> * feat(useStoage): listen to `storage` event (#2298) * feat: sync `storage` state * chore: update test case * refactor: replace StorageEvent to CustomEvent, and add listenStorageChange param * test: revert case in useSessionStorage * docs: modify docs and demo * test: add case for 'enable' parameter * test: remove unnecessary code --------- Co-authored-by: liuyib <[email protected]> * chore(useLatest): add a default state for comparison in useLatest demo (#2523) * feat(useSelections): support object array (#2485) * feat(useSelections): support object array * fix: solve error * 修复 useAntdTable Params 的类型问题 (#2377) * fix(useAntdTable): change Params filter to filters * docs(useAntdTable): change Params filter to filters * fix(useVirtualList): get correct offset when itemHeight is fixed (#2279) Co-authored-by: huangcheng <[email protected]> --------- Co-authored-by: Guo Yunhe <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: guaijie <[email protected]> Co-authored-by: joe-leong <[email protected]> Co-authored-by: 潇见 <[email protected]> Co-authored-by: Darwish <[email protected]> Co-authored-by: vaakian <[email protected]> Co-authored-by: shanyue <[email protected]> Co-authored-by: Conor <[email protected]> Co-authored-by: echo <[email protected]> Co-authored-by: huangcheng <[email protected]>
crazylxr
added a commit
that referenced
this pull request
May 13, 2024
* refactor: replace lodash/isEqual with react-fast-compare (#2458) * refactor: replace lodash/isEqual with react-fast-compare * chore: update lock --------- Co-authored-by: 云泥 <[email protected]> * refactor(useRafInterval): optimize useEffect cleanup fn (#2426) * fix(useAntdTable): 修复动态设置 ready 失效的 bug (#2489) * refactor(useLockFn): catch to finally (#2421) * refactor(useLockFn): catch to finally * refactor(useLockFn): keep the throw e * refactor(createEffectWithTarget): the first parameter is old-deps (#2431) * fix(useCountDown): targetDate resets leftTime (#2346) * chore: update version * fix(type): fixed up some types that are non-standard and errors on `useExteneral` hook (#2508) * fix(type): fixed up some types that are non-standard and errors on `useExternal` hook * style: format * refactor: simplify --------- Co-authored-by: liuyib <[email protected]> * feat(useStoage): listen to `storage` event (#2298) * feat: sync `storage` state * chore: update test case * refactor: replace StorageEvent to CustomEvent, and add listenStorageChange param * test: revert case in useSessionStorage * docs: modify docs and demo * test: add case for 'enable' parameter * test: remove unnecessary code --------- Co-authored-by: liuyib <[email protected]> * chore(useLatest): add a default state for comparison in useLatest demo (#2523) * feat(useSelections): support object array (#2485) * feat(useSelections): support object array * fix: solve error * 修复 useAntdTable Params 的类型问题 (#2377) * fix(useAntdTable): change Params filter to filters * docs(useAntdTable): change Params filter to filters * fix(useVirtualList): get correct offset when itemHeight is fixed (#2279) Co-authored-by: huangcheng <[email protected]> * fix(createUseStorageState): invoke setState twice (#2532) * fix: 🐞 every add default value (#2529) * feat(useDynamicList): add `batchRemove` method (#2340) * feat: useDynamicList添加批量删除 * fix: list key * ci: add case for batchRemove * chore: add batchRemove to demo * fix: better warn * test: update --------- Co-authored-by: xiaozisong <[email protected]> Co-authored-by: liuyib <[email protected]> * feat(useSelections): add clearAll result (#2357) * feat(useSelections): add clearAll result * docs: update docs and code style * refactor: resolve conflict * docs: update --------- Co-authored-by: liuyib <[email protected]> * test(useSelections): fix test case error (#2536) * test: fix case * style: rename --------- Co-authored-by: Guo Yunhe <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: guaijie <[email protected]> Co-authored-by: joe-leong <[email protected]> Co-authored-by: 潇见 <[email protected]> Co-authored-by: Darwish <[email protected]> Co-authored-by: vaakian <[email protected]> Co-authored-by: shanyue <[email protected]> Co-authored-by: Conor <[email protected]> Co-authored-by: echo <[email protected]> Co-authored-by: huangcheng <[email protected]> Co-authored-by: 左耳咚 <[email protected]> Co-authored-by: shawn <[email protected]> Co-authored-by: xiaozisong <[email protected]> Co-authored-by: lich-yoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
react-fast-compare 提供了与 lodash/isEqual 相同的能力，但是体积更小，性能快了数倍。
📝 Changelog
☑️ Self Check before Merge