Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dev #117

wants to merge 3 commits into from

Conversation

mumrik58
Copy link

@mumrik58 mumrik58 commented May 30, 2018

Hi, I like your project, so please let me contribute you.
I hope you check and review this request.

I have added 4 files.

3 files are for Docker.
Basically, the setup process have followed your readme.markdown.
And in addition, I have cared a proxy environment.

  • Dockerfile
    This is a Dockerfile for the main application container of the Scrumblr.
  • docker-compose.yml
    This is a docker-compose.yml to compose a Scrumblr container and a Redis container.
  • .env
    This is an environment configuration file.
    docker-compose.yml refers this file to resolve $version, $http_proxy, $https_proxy and $no_proxy.

1 file is for fixing a client 404 error.

  • client/images/ui-icons_222222_256x240.png
    In my environment, Chrome browser:Version 66.0.3359.181 on Max OS X High Sierra had a 404 error of this file. So I got this file from your demo site and put it here.

Thank you ; )

ocdtrekkie added a commit to ocdtrekkie/scrumblr that referenced this pull request May 30, 2018
@mumrik58 pointed this out in upstream PR aliasaria#117
@ocdtrekkie
Copy link

Definitely can confirm that missing image error on the Sandstorm package I built for Scrumblr. Nice catch.

@ocdtrekkie
Copy link

I think the only place it's used on the boards is here, as far as I can tell:

image

This icon doesn't appear on my Sandstorm package, though resize does still work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants