Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default frame time on missing video duration metadata #306

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DurandA
Copy link

@DurandA DurandA commented Aug 28, 2023

PR Goal

Prevent exception when generating a preview on a video with missing duration metadata. duration metadata is typically missing on webm files recorded using the MediaStream Recording API. There is even a JS package to add duration to webm files.

Implemented solution

If there is no duration metadata, take the first frame rather than throwing a KeyError.

Checkpoints

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
  • Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
  • The PR or the original issue contains a short summary of the implemented solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant