feat(popup-header): add popup-header component #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artptr
requested review from
GREENpoint,
Heymdall,
stepancar,
ivliag,
tx44 and
ziimir
GREENpoint
reviewed
Jul 20, 2017
| @@ -0,0 +1,10 @@ | |||
| ``` | |||
There was a problem hiding this comment.
Я думаю нужно показывать в сборке с popup-ом.
There was a problem hiding this comment.
Заменить или дополнить?
src/popup-header/popup-header.jsx
Outdated
| className={ cn('closer') } | ||
| size={ this.props.size } | ||
| icon='close' | ||
| onClick={ this.props.onCloseClick } |
There was a problem hiding this comment.
ноу. через handler и проверку есть или нет внешнего пропса, иначе будет ошибка, если обработчик непередан.
GREENpoint
approved these changes
Jul 20, 2017
stepancar
reviewed
Jul 20, 2017
src/popup-header/README.md
Outdated
| ) } | ||
| visible={ this.state.popup } | ||
| > | ||
| <div>Lorem ipsum dolor sit amet, consectetur adipiscing elit,</div> |
There was a problem hiding this comment.
Сделай пожалуйста осмысленную демку на русском языке. Запрос от дизайнера
artptr
force-pushed
the
feat/popup-header
branch
from
75a3a50
to
e50edce
Compare
ziimir
approved these changes
Jul 20, 2017
stepancar
approved these changes
Jul 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Компонент заголовка для попапа.
Мотивация и контекст
Выносим типовой хедер на уровень компонента для переиспользования в типичных полноэкранных попапах — select, calendar-input и т.п.