Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor perf improvements and allow to get certificate information externally #131

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

molinch
Copy link

@molinch molinch commented Sep 16, 2024

Hey @alexalok

Would you be open to a small PR?

It improves performance when creating the ApnsClient from a certificate and allows external usage of GetCertificateInfo.

Performance changes:

  • Don't allocate the array used for splitting (single reused instance)
  • Avoid re-splitting
  • Avoid operations when non VoIP, and use substring instead of Replace

Copy link
Owner

@alexalok alexalok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @molinch,

Thank you for your improvements! LGTM, will release a new nuget version shortly.

@alexalok alexalok merged commit cf26e91 into alexalok:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants