rgw: silence compilation #warnings

these are now FIXMEs Signed-off-by: Yehuda Sadeh <[email protected]>
albertghtoun · Feb 18, 2016 · d95fcfa · d95fcfa
1 parent 996e6e9
commit d95fcfa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc
@@ -2772,8 +2772,6 @@ int main(int argc, char **argv)
 	  return -ret;
 	}
 
-        #warning need to implement for backward compatabilty
-
 	if (reset_regions) {
           zonegroupmap.zonegroups.clear();
         }

diff --git a/src/rgw/rgw_data_sync.cc b/src/rgw/rgw_data_sync.cc
@@ -484,7 +484,7 @@ class RGWListBucketIndexesCR : public RGWCoroutine {
                                                   oid_prefix);
       yield {
         string entrypoint = string("/admin/metadata/bucket.instance");
-#warning need a better scaling solution here, requires streaming output
+        /* FIXME: need a better scaling solution here, requires streaming output */
         call(new RGWReadRESTResourceCR<list<string> >(store->ctx(), sync_env->conn, sync_env->http_manager,
                                                       entrypoint, NULL, &result));
       }
@@ -694,7 +694,7 @@ class RGWDataSyncSingleEntryCR : public RGWCoroutine {
         yield call(sync_env->error_logger->log_error_cr(sync_env->conn->get_remote_id(), "data", bucket_name + ":" + bucket_instance,
                                                         -sync_status, string("failed to sync bucket instance: ") + cpp_strerror(-sync_status)));
       }
-#warning what do do in case of error
+      /* FIXME: what do do in case of error */
       if (!entry_marker.empty()) {
         /* update marker */
         yield call(marker_tracker->finish(entry_marker));

diff --git a/src/rgw/rgw_sync.cc b/src/rgw/rgw_sync.cc
@@ -659,7 +659,7 @@ class RGWFetchAllMetaCR : public RGWCoroutine {
       for (; sections_iter != sections.end(); ++sections_iter) {
         yield {
 	  string entrypoint = string("/admin/metadata/") + *sections_iter;
-#warning need a better scaling solution here, requires streaming output
+          /* FIXME: need a better scaling solution here, requires streaming output */
 	  call(new RGWReadRESTResourceCR<list<string> >(cct, conn, sync_env->http_manager,
 				       entrypoint, NULL, &result));
 	}
@@ -963,7 +963,7 @@ int RGWMetaSyncSingleEntryCR::operate() {
       sync_status = retcode;
 
       if (sync_status == -ENOENT) {
-#warning remove entry from local
+        /* FIXME: do we need to remove the entry from the local zone? */
         break;
       }