rgw: don't try to parse some forwarded requests

Not every forwarded requests are expected to get a json response, don't pass the parser when not needed. Signed-off-by: Yehuda Sadeh <[email protected]>
albertghtoun · Feb 15, 2016 · 3c28f19 · 3c28f19
1 parent 842140b
commit 3c28f19
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc
@@ -1718,7 +1718,7 @@ static int forward_request_to_master(struct req_state *s, obj_version *objv, RGW
     return ret;
 
   ldout(s->cct, 20) << "response: " << response.c_str() << dendl;
-  if (!jp->parse(response.c_str(), response.length())) {
+  if (jp && !jp->parse(response.c_str(), response.length())) {
     ldout(s->cct, 0) << "failed parsing response from master zonegroup" << dendl;
     return -EINVAL;
   }
@@ -1934,9 +1934,8 @@ void RGWDeleteBucket::execute()
 
   if (!store->is_meta_master()) {
     bufferlist in_data;
-    JSONParser jp;
     op_ret = forward_request_to_master(s, &ot.read_version, store, in_data,
-				       &jp);
+				       NULL);
     if (op_ret < 0) {
       if (op_ret == -ENOENT) {
         /* adjust error, we want to return with NoSuchBucket and not
@@ -4350,9 +4349,8 @@ bool RGWBulkDelete::Deleter::delete_single(const acct_path_t& path)
 
     if (!store->get_zonegroup().is_master) {
       bufferlist in_data;
-      JSONParser jp;
       ret = forward_request_to_master(s, &ot.read_version, store, in_data,
-				      &jp);
+				      NULL);
       if (ret < 0) {
         if (ret == -ENOENT) {
           /* adjust error, we want to return with NoSuchBucket and not