Add About section in Settings Dialog #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Dialogs/SettingsDialog.vala
Outdated
| grid.halign = Gtk.Align.CENTER; | ||
|
|
||
| var app_icon = new Gtk.Image (); | ||
| app_icon.gicon = new ThemedIcon ("com.github.akiraux.akira"); |
There was a problem hiding this comment.
We can use Config.APP_ID here
There was a problem hiding this comment.
Definitely! Icon is not render on flatpak
|
@albfan @bilelmoussaoui, patch updated, can you confirm the icon is visible now? |
|
Works fine here, I totally forgot there was a "development" version of the icon :D |
bilelmoussaoui
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
Add an
Aboutsection in the Settings Dialog.Steps to Test
Open the Settings Dialog and access the About Tab.
Screenshots
This PR fixes/implements the following bugs/features:
Add About dialog.
Show Akira version from meson file.
Implement an MD file to list all the Patreon supporters.
Fixes Display Akira version #328